1555232 - [Protections Panel] Protection Settings section

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P1)

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1555232 - Protections panel: add settings section. r=johannh

Depends on D33730

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1555232 - Protections panel: boost base font size for all elements. r=johannh

Depends on D33972

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Tim is going to work on this.

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1555232 - Part 1: Add the protection settings section into Protection Panel. r?nhnt11!

This patch adds a protection settings section into Protection Panel.
This section consist of one button which will open a
'about:preferences#privacy' when been clicked.

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1555232 - Part 2: Add a test case for the protection settings button. r?nhnt11!

This patch add a test for ensuring the protection settings button works
correctly. It will open a tab and its protection panel. Clicking the
protection settings button and chekcing if the about:preferences has
been opened properly or not.

Depends on D34873

Comment 6

[Tim Huang[:timhuang]]

Hi Bryan,

Would you be able to give more details on the protection settings section? Like details regarding hover states, etc. Right now, I am using the same behavior as hovering on the Content Blocking section in identity panel. But I am wondering that if is there a new design for the protection panel. Thanks.

Comment 7

[Tim Huang[:timhuang]]

Try looks good, landing.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eb2725715f38959d1ea4fa35750a06850d7ae1f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/819f4a8cd149
Part 1: Add the protection settings section into Protection Panel. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/f97628b002de
Part 2: Add a test case for the protection settings button. r=nhnt11

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/819f4a8cd149
https://hg.mozilla.org/mozilla-central/rev/f97628b002de