1555284 - FindBar lost focus when switching tab by mouse click on tab

Status: NEW

(Firefox :: Tabbed Browser, defect, P3)

Description

[Alice0775 White]

This is regression since Firefox63.
The problem happens if switching tab by mouse click on tab
The problem does not happen if switch tabs by keyboard(Ctrl+1, Ctrl+2).
(If the bug happens when quickly switching tabs, this may be different bug)

Steps To Reproduce:

1. Open 2 tabs (e.g, https://archive.mozilla.org/pub/firefox/nightly/ in each tabs)
2. Open FindBar(Ctrl+F)
   --- FindBar is getting focus as expected, Caret appears in FindBar as expected.
3. wait for 1 second
4. Switch to the other tab by mouse click tab
5. wait for 1 second
6. Switch back to the original tab by mouse click tab
   --- observe, focus of FindBar, caret disappear

Actual Results:
Contents area seems to steal focus.
FindBar lost focus.

Expected Results:
FindBar should maintain the state of the focus.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dbd045e6bb9c86ee75a207e80dd6b9103624e51a&tochange=a022c40e4d55f303bbaac93b33447faa02e93add

Regressed by:
a022c40e4d55f303bbaac93b33447faa02e93add Mike Conley — Bug 1478112 - Get rid of preselect tabbox workaround, and adjust focus after changing visible tab right away. r=dao

Mike Conley,
Your patch seems to cause the regression. Can you please look into this?

Comment 1

[Liz Henry (:lizzard)]

Happy to take a patch for 70 but since this is triaged and set to P3 priority I'm setting it as fix-optional.
That will remove the bug from weekly regression triage.