1555425 - Enable Web Authentication in all Android channels

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

There are no showstopping bugs for Web Authentication on Android, so while we wait for QA sign-off, let's go ahead and pref it on. If we need, we can pref-back-off in a later Beta.

Comment 1

[J.C. Jones [:jcj] (he/they)]

Ryan, is there any pref for "Just Fennec, not Fenix" beyond FENNEC_NIGHTLY? Otherwise, I think we just want maybe to land directly into mozilla-beta so as to not turn on in Fenix unexpectedly?

Comment 2

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1555425 - Enable Web Authentication in all Fennec Android channels

Comment 3

[Ryan VanderMeulen [:RyanVM]]

(In reply to J.C. Jones [:jcj] (he/him) from comment #1)

Ryan, is there any pref for "Just Fennec, not Fenix" beyond FENNEC_NIGHTLY? Otherwise, I think we just want maybe to land directly into mozilla-beta so as to not turn on in Fenix unexpectedly?

I don't think we can selectively enable for just Fennec. Also, I'm not sure if landing this on Beta won't affect Fenix. I think we're using GV Beta builds for Fenix? Though TBH, I'm having a bit of a hard time keeping straight which GeckoView is being used in which products.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

For prefs, you can enable in mobile.js for Fennec and disable in geckoview-prefs.js for GeckoView.

Comment 5

[Chris Peterson [:cpeterson]]

68=affected because we'll want to uplift this fix to Fennec 68 Beta.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b871bf099557
Enable Web Authentication in all Fennec Android channels r=cpeterson,KevinJacobs

Comment 7

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9068461 [details]
Bug 1555425 - Enable Web Authentication in all Fennec Android channels

Beta/Release Uplift Approval Request

• User impact if declined: No WebAuthn on Android until Fenix can adopt the feature (which is pending whitelist updates)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: (Just a pref flip)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Has received QE signoff. Just a pref-flip to enable.
• String changes made/needed: None

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b871bf099557

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9068461 [details]
Bug 1555425 - Enable Web Authentication in all Fennec Android channels

webauthn for fennec beta/release, approved for 68.0b9

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bcbe8270b31