1555427 - Skip mozalloc_abort and similar frames when determining crash signature

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Kris Maglione [:kmag]]

We have hundreds of unrelated bugs with the crash signature "@ mozalloc_abort" because it winds up being the top frame for most types of aborts. We should skip that and related abort functions when determining the crash signature so it actually winds up being useful.

We apparently already do something similar on socorro.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1555427: Skip abort functions when determining crash signature. r=gbrown

mozalloc_abort and related abort functions are the top frame for many
different, unrelated crashes because they happen to be the standard way to
abort execution. That makes it difficult to properly classify and deal with
intermittent failures.

This patch changes our crash handling behavior so that we try to skip any
frames at the top of the stack that are in generic abort functions, and use
the topmost frame which is actually relevant to the crash reason instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65ccd8aad15a
Skip abort functions when determining crash signature. r=gbrown

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/65ccd8aad15a