1555551 - ROLE_SPINBUTTON accessible (input type="number") nested inside a label element does not have a labelled by relationship.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Test url:

data,text/html,<label>Spin button label: <input type="number"></label>

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Jamie, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I think this might have been fixed? At least, uncommenting the test case that was disabled for this (https://searchfox.org/mozilla-central/rev/3cb31675aeffd10f1f6ae7c40e24b254da7798e5/devtools/server/tests/browser/browser_accessibility_text_label_audit.js#913-914), the test passes.

I guess we can use this bug to land uncommenting the test.

It would be nice to know where and when this was fixed so we can hopefully apply the same principal for Bug 1779954.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1555551 - [devtools] Enable test case checking spinbutton inside number input doesn't trigger FORM_NO_NAME error. r=Jamie.

It looks like the underlying issue was fixed at some point
as the test passes with the test case enabled.

Comment 4

[James Teh [:Jamie]]

This was almost certainly fixed by bug 981248. Previously, <input type="number"> exposed an anonymous input field inside the form control, which caused problems for a11y relations. After bug 981248, there's no anonymous input any more, so a11y relations work as expected.

Bug 1779954 is different because time inputs need to expose multiple inputs inside them. I think we're just going to need to have an exception for that case in the inspector. I'll comment on that bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fdc469d3d05
[devtools] Enable test case checking spinbutton inside number input doesn't trigger FORM_NO_NAME error. r=Jamie.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8fdc469d3d05