Closed Bug 1555589 Opened 8 months ago Closed 8 months ago

redefinition of prctl_* on non glibc archs due to sys/prctl.h

Categories

(Core :: Security: Process Sandboxing, defect, P3)

68 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 - fixed
firefox69 --- fixed

People

(Reporter: anarchy, Assigned: gcp)

Details

Attachments

(2 files, 1 obsolete file)

There is no reason we can not just use sys/prctl.h instead of linux/prctl.h

glibc's header already has the include handled via sys/prctl.h and musl has an almost identifical copy of the linux/prctl.h with a very few modifications.

Flags: needinfo?(gpascutto)
Priority: -- → P3
Flags: needinfo?(gpascutto)
Assignee: nobody → gpascutto
Pushed by gpascutto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eba3d102aaae
Include sys/prctl.h not linux/prctl.h. r=jld
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Gian-Carlo Pascutto any reason you felt the need to take credit for the patch when it was a duplicate patch just added to the fabricator? Well I do not need the credit for the fix, it is nice to ensure the proper users are getting credit for their contributions to the project.

Also do you see any reason we should not request this to land on mozilla-beta? There are quiet a few linux distros that are using musl now days.

[Tracking Requested - why for this release]:

Gian-Carlo Pascutto any reason you felt the need to take credit for the patch when it was a duplicate patch just added to the fabricator? Well I do not need the credit for the fix, it is nice to ensure the proper users are getting credit for their contributions to the project.

I agree! Your patch doesn't have the author field set and it looks that when I re-uploaded it into Phrabricator, Mercurial took a guess at it and tried to fill in the blanks: https://bug1555589.bmoattachments.org/attachment.cgi?id=9068623

You can put a section like this in your .hgrc:

[ui]
username = Jory A. Pratt <anarchy@gentoo.org>

https://www.mercurial-scm.org/doc/hgrc.5.html#ui

Also do you see any reason we should not request this to land on mozilla-beta? There are quiet a few linux distros that are using musl now days.

Sounds fine by me. Let me see if I can re-mangle that patch to have you as the author and I'll submit the request.

Let me see if I can re-mangle that patch to have you as the author and I'll submit the request.

This hit bug 1538151 so we'll need to wait till jld re-approves.

(In reply to Gian-Carlo Pascutto [:gcp] from comment #7)

You can put a section like this in your .hgrc:

[ui]
username = Jory A. Pratt <anarchy@gentoo.org>

https://www.mercurial-scm.org/doc/hgrc.5.html#ui

Appears upstream has moved to requiring -U be passed for currentuser to be added properly. Sorry for the noise. I have found the problem on my end and will adjust with an alias. I am looking at what all I need to do for fabricator submission now.

Comment on attachment 9070210 [details]
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. rs=jld

Beta/Release Uplift Approval Request

  • User impact if declined: Build failure on various Linux distributions
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No expected functional impact.
  • String changes made/needed:
Attachment #9070210 - Flags: approval-mozilla-beta?

Comment on attachment 9070210 [details]
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. rs=jld

build fix for musl libc, approved for 68.0b9

Attachment #9070210 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Not sure if releng pulled the beta fix from the nightly tree instead of from Phabricator, or something again clobbered the author field, but beta also landed with the wrong author attribution. Sorry about that.

Attachment #9070210 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.