1555589 - redefinition of prctl_* on non glibc archs due to sys/prctl.h

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P3)

Description

[Jory A. Pratt [:anarchy]]

Attachment: 2013_Fix_bad_include_prctl.patch

There is no reason we can not just use sys/prctl.h instead of linux/prctl.h

glibc's header already has the include handled via sys/prctl.h and musl has an almost identifical copy of the linux/prctl.h with a very few modifications.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r?jld

Comment 2

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eb3565df263f0de0f6b44153e586abf1cc36ca9

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eba3d102aaae
Include sys/prctl.h not linux/prctl.h. r=jld

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/eba3d102aaae

Comment 5

[Jory A. Pratt [:anarchy]]

Gian-Carlo Pascutto any reason you felt the need to take credit for the patch when it was a duplicate patch just added to the fabricator? Well I do not need the credit for the fix, it is nice to ensure the proper users are getting credit for their contributions to the project.

Also do you see any reason we should not request this to land on mozilla-beta? There are quiet a few linux distros that are using musl now days.

Comment 6

[Jory A. Pratt [:anarchy]]

[Tracking Requested - why for this release]:

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Gian-Carlo Pascutto any reason you felt the need to take credit for the patch when it was a duplicate patch just added to the fabricator? Well I do not need the credit for the fix, it is nice to ensure the proper users are getting credit for their contributions to the project.

I agree! Your patch doesn't have the author field set and it looks that when I re-uploaded it into Phrabricator, Mercurial took a guess at it and tried to fill in the blanks: https://bug1555589.bmoattachments.org/attachment.cgi?id=9068623

You can put a section like this in your .hgrc:

[ui]
username = Jory A. Pratt <[e-mail]>

https://www.mercurial-scm.org/doc/hgrc.5.html#ui

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Also do you see any reason we should not request this to land on mozilla-beta? There are quiet a few linux distros that are using musl now days.

Sounds fine by me. Let me see if I can re-mangle that patch to have you as the author and I'll submit the request.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1555589 - Include sys/prctl.h not linux/prctl.h. rs=jld

Comment 10

[Gian-Carlo Pascutto [:gcp]]

Let me see if I can re-mangle that patch to have you as the author and I'll submit the request.

This hit bug 1538151 so we'll need to wait till jld re-approves.

Comment 11

[Jory A. Pratt [:anarchy]]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #7)

You can put a section like this in your .hgrc:

[ui]
username = Jory A. Pratt <[e-mail]>

https://www.mercurial-scm.org/doc/hgrc.5.html#ui

Appears upstream has moved to requiring -U be passed for currentuser to be added properly. Sorry for the noise. I have found the problem on my end and will adjust with an alias. I am looking at what all I need to do for fabricator submission now.

Comment 12

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 9070210 [details]
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. rs=jld

Beta/Release Uplift Approval Request

• User impact if declined: Build failure on various Linux distributions
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No expected functional impact.
• String changes made/needed:

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9070210 [details]
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. rs=jld

build fix for musl libc, approved for 68.0b9

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/121bb8154383

Comment 15

[Gian-Carlo Pascutto [:gcp]]

Not sure if releng pulled the beta fix from the nightly tree instead of from Phabricator, or something again clobbered the author field, but beta also landed with the wrong author attribution. Sorry about that.