1555661 - Google is listing two client codes in the search url

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Mark Banner (:standard8)]

This was noticed in bug 1554912, but splitting out as it seems a slightly different issue.

The URLs we're generating for google searches contain two client parameters, e.g. https://www.google.com/search?client=firefox-b-d&q=test&client=firefox-b-ab

firefox-b-ab is an old code, and firefox-b-d is the correct code. This is most likely a regression from bug 1496075.

The issue is that browser/components/search/extensions/google/_locales/b-d/messages.json doesn't have a param_keyword listing. As a result, the extension falls back to using the en value, which has the old param_keyword of firefox-b-ab.

As far as I know we don't use the old codes at all, so I think we should remove those locale options, and simplify the manifest.json for Google.

I'll also add a tests and do a quick check of the other multi-locales.

Tracking for 68, as this is a regression there and we need this fixing for it.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1555661 - Fix client code inclusion in Google urls. r?daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5906d50f330
Fix client code inclusion in Google urls. r=daleharvey

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset c5906d50f330 for failures at LocaleService.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/0e31bdc88d2731836d466b497610d92402987f03

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c5906d50f33036157354b073cfedc441f4b25dba&selectedJob=249343689

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249343689&repo=autoland&lineNumber=1548

Comment 4

[Mark Banner (:standard8)]

Ok, it looks like it doesn't like having the default locale as "b-d". I'll add en back and make it default to the same as b-d. That doesn't functionally change anything, and when we do the modernisation of the search config, we'll be pulling the codes out of the extensions, so we should be able to drop this multi-locale setup for Google at least.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/858d04f452e2
Fix client code inclusion in Google urls. r=daleharvey

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 858d04f452e2 (bug 1555661) for Build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249355294&repo=autoland&lineNumber=39456

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=858d04f452e2d4344a79dd83dc49749c41162c7e

Backout:
https://hg.mozilla.org/integration/autoland/rev/80554fedd3aa7fb1d52dc1c83abb226e0c6046fe

Comment 7

[Mark Banner (:standard8)]

Ok, latest backout was due to the files now being duplicates. I've added a bit of whitespace and that seems to fix it. As I said before, we can hopefully remove this later, but for now we need this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70d1aed47149
Fix client code inclusion in Google urls. r=daleharvey

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/70d1aed47149

Comment 10

[Mark Banner (:standard8)]

QE Verify: Please check that the URLs contain only one "client" parameter for both US region based en-US, and for a locale where the region is also outside of the US (xref bug 1554912 comment 0).

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 9068705 [details]
Bug 1555661 - Fix client code inclusion in Google urls. r?daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: None, however product search codes may be invalid.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See previous comment
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple well-defined fixes to just the Google search engine setup, covered by tests.
• String changes made/needed: None

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9068705 [details]
Bug 1555661 - Fix client code inclusion in Google urls. r?daleharvey

google search codes fix, approved for 68.0b7

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d9d20f173e3

Comment 14

[Anca Soncutean, Desktop QA]

I’ve reproduced the issue with Fx 69.0a1 (2019-05-30) on Windows 10 x64.
I can’t see any duplicate client codes in the search url with different locales and different regions using Nord VPN (eg. en-US, en-GB, fr, de, ru, ja, zh-CN, es-Es, pl, nn-NO, it) with Fx 69.0a1 (2019-06-04) and Fx 68.0b7 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.

Comment 15

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.