1555751 - Support Kotlin syntax highlighting in file preview

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P5)

Description

[:Harald Kirschner :digitarald]

Debugger should support Kotlin as source mapped language and syntax highlight it correctly.

https://kotlinlang.org/docs/tutorials/javascript/kotlin-to-javascript/kotlin-to-javascript.html

Via https://discourse.mozilla.org/t/kotlin-sourcemap-debug-support/40966

Comment 1

[Jason Laster [:jlast]]

codemirror has a mode for it so we can easily add this
http://lig-coin.imag.fr/COIN3D/ThirdParty/codemirror-4.6/mode/kotlin/index.html

Comment 2

[Krishnal Ciccolella]

Hello,

I would like to take a stab at this.

Comment 3

[Jason Laster [:jlast]]

Go for it

Comment 4

[Varun [he/him IST]]

Hi I would like to start working on it but would need some help as to where to start from

Comment 5

[Jason Laster [:jlast]]

Here are our codemirror modes
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/editor/source-editor.js#16

there are some docs in
https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/README

Comment 6

[Varun [he/him IST]]

Hey Jason. Seems like we already have kotlin mode imported in clike.js at
https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/codemirror/mode/clike/clike.js#596

Also the handling of kotlin file type is handled in getMode method at following line
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/source.js#367

Can you help me if there is any config file which I am missing out that needs to be modified in order to source map kotlin file?

Comment 7

[Jason Laster [:jlast]]

Hmm, those things exist, but we're still not seeing the syntax highlighting?

Comment 8

[Varun [he/him IST]]

Attachment: Kotlin syntax highlighting

Comment 9

[Varun [he/him IST]]

Syntax highlighting is present but is not as concise as it would be for javascript. I have attached the screenshot of the same.

Comment 10

[Jason Laster [:jlast]]

That is likely a codemirror issue. I don't know if there is anything we can do from our end.