1555752 - Hard to determine that wrong Pulse credentials have been used

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement, P3)

Description

[Armen [:armenzg]]

If a user tries to follow the Pulse instructions and uses the wrong credentials the command to ingest will not fail. It will just do nothing.

I'm happy to fix this with some direction.

root@2c14ad4a3716:/app# ./manage.py pulse_listener_jobs
/app/treeherder/etl/schema.py:13: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  schema = yaml.load(f)
/usr/local/lib/python3.7/site-packages/rest_framework/exceptions.py:18: DeprecationWarning: 'version' is deprecated. Use '__version__' instead.
  from rest_framework.compat import unicode_to_repr

Comment 1

[Karl Thiessen [:kthiessen, he/him]]

Moving to P2 and assigning to :armenzg. Armen, feel free to ping folks in #treeherder or needinfo if you get blocked.

Comment 2

[Suyash Salampuria]

I would like to takle this one.
I think that it just needs to be cheecked where the connection is made to the pulseguardian and we add the catch the errors and give error logs in the terminal

Comment 3

[Armen [:armenzg]]

Hi Suyash,
It might be simply that in the past (2 months ago) the logger was set up to only show warning level messages.

Comment 4

[Suyash Salampuria]

Hi armen, I see that on using the wrong credentials, we get this message on terminal
amqp.exceptions.AccessRefused: (0, 0): (403) ACCESS_REFUSED - Login was refused using authentication mechanism AMQPLAIN. For details see the broker logfile.

I don't think that we need to do anything in this for now
WDYT Armen

Comment 5

[Armen [:armenzg]]

This is probably because we were only logging warning messages.

Thanks for checking!