1555805 - Assertion failure in nsFaviconService.cpp: NS_SUCCEEDED(rv)

Status: RESOLVED INVALID

(Toolkit :: Places, defect)

Description

[(no longer active)]

We start from NotifyIconObservers::NotifyIconObservers(). Here aPage is "https://planet.mozilla.org/" and aIcon.spec is "fake-favicon-uri:https://planet.mozilla.org/".

Then we get to https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/toolkit/components/places/nsFaviconService.cpp#269.

Here pageIconSpec is "page-icon:https://blog.nightly.mozilla.org/". The URL parsing fails and rv is NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED.

Setting a breakpoint here shows that the missing method is nsIProtocolHandler.newURI().

My guess is that this code has failed somehow? (That is one weird way of creating URIs especially since in newChannel it uses the conventional way!)

I came across this BTW when running ./mach test browser_partitionedLocalStorage_events.js --debugger=rr --disable-e10s. The issue was reproducible... Also happened with ./mach run.

Comment 1

[(no longer active)]

D'oh, looks like this was caused by an out of date objdir, presumably the jsm file would fail to load or something like that... Sorry about this.