1555825 - [webvtt] enable wpt 'track-cue-empty.html'.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

According to the spec [1], text node has a value to represent its text, even when its text is an empty string.

Therefore, when calling getCueAsHTML() on a cue with empty text, we should append a text node with a value for empty text string on the DocumentFragment we return.

[1] https://w3c.github.io/webvtt/#webvtt-text-object

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1555825 - part1 : append a text node with empty value when input is an empty string.

According to the spec [1], text node has a value to represent its text, even when its text is an empty string.

Therefore, we should append a text node with a value for empty text string on the DocumentFragment we return, when input sting is an empty string.

[1] https://w3c.github.io/webvtt/#webvtt-text-object

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1555825 - part2 - enable wpt 'track-cue-empty.html'.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd28cba6e75a
part1 : append a text node with empty value when input is an empty string. r=heycam
https://hg.mozilla.org/integration/autoland/rev/ef12596e2d0b
part2 - enable wpt 'track-cue-empty.html'. r=heycam

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fd28cba6e75a
https://hg.mozilla.org/mozilla-central/rev/ef12596e2d0b