Closed Bug 1555825 Opened 1 year ago Closed 1 year ago

[webvtt] enable wpt 'track-cue-empty.html'.

Categories

(Core :: Audio/Video: Playback, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

According to the spec [1], text node has a value to represent its text, even when its text is an empty string.

Therefore, when calling getCueAsHTML() on a cue with empty text, we should append a text node with a value for empty text string on the DocumentFragment we return.

[1] https://w3c.github.io/webvtt/#webvtt-text-object

According to the spec [1], text node has a value to represent its text, even when its text is an empty string.

Therefore, we should append a text node with a value for empty text string on the DocumentFragment we return, when input sting is an empty string.

[1] https://w3c.github.io/webvtt/#webvtt-text-object

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd28cba6e75a
part1 : append a text node with empty value when input is an empty string. r=heycam
https://hg.mozilla.org/integration/autoland/rev/ef12596e2d0b
part2 - enable wpt 'track-cue-empty.html'. r=heycam
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.