1555854 - many CryptoTasks could probably use the stream transport service instead of creating threads

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

See the conversation in bug 1555557. Basically, for most CryptoTasks in PSM, we can probably use the stream transport service as an event target rather than creating new threads every which-where.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1555854 - avoid creating transient threads in PSM (particularly CryptoTask) r?KevinJacobs

CryptoTask is a helper class that makes it easier to implement code that runs on
a background thread and then notifies completion on the main thread (this is
useful for not blocking the main thread with long-running cryptography or I/O).
Before this patch, each CryptoTask would create a new thread each time it ran,
which was inefficient. This patch updates CryptoTask to use the stream transport
service (which is essentially a pool of threads for doing exactly these kinds of
things and notably is not to be confused with the socket transport service) to
run each task. Additionally, there were a few places in PSM where we
unnecessarily created new threads to perform similar tasks. These now use the
stream transport service as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/840986a64dbf
avoid creating transient threads in PSM (particularly CryptoTask) r=KevinJacobs

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/840986a64dbf

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af5896622716
Port bug 1555854 - adapt to change in signature of CryptoTask::Dispatch; rs=bustage-fix

Comment 5

[(no longer active)]

Thanks a lot for taking care of this, Dana!