Closed
Bug 1555867
Opened 5 years ago
Closed 5 years ago
Measure how common single children in the rule tree are, and consider not using a hashmap in that case.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
See bug 1554852's discussion.
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(emilio)
Assignee | ||
Comment 1•5 years ago
|
||
This is useful to analyze the shape of the rule tree at a glance.
Assignee | ||
Comment 2•5 years ago
|
||
It is indeed the most common case according to a bit of measurement.
A non-atypical example from GitHub for example:
Rule tree stats:
0 - 340
1 - 1403
2 - 28
3 - 8
4 - 2
6 - 1
7 - 3
8 - 2
12 - 2
14 - 1
41 - 1
45 - 1
67 - 1
68 - 1
Depends on D33350
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D33351
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f4773f8b9a5
Add some very basic rule tree stats that can be enabled with trace-level logging. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d7e316a88009
Inline one child in the rule tree. r=heycam
https://hg.mozilla.org/integration/autoland/rev/e48148b2edf7
Report heap size of rule tree heap allocations as well. r=heycam
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f4773f8b9a5
https://hg.mozilla.org/mozilla-central/rev/d7e316a88009
https://hg.mozilla.org/mozilla-central/rev/e48148b2edf7
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•