1555876 - IDBFactory::CreateForMainThreadJS should use storage principal

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[(no longer active)]

https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/dom/indexedDB/IDBFactory.cpp#170

I don't believe this matters in practice currently for the current consumers (we use this function to attach the IDB factory to the Sandbox and XPCOM Components contexts). But it may matter some day for another consumer...

Comment 1

[(no longer active)]

Attachment: Bug 1555876 - Part 2: Use storage principal in IDBFactory::CreateForMainThreadJS();

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17a2436c527e
Use storage principal in IDBFactory::CreateForMainThreadJS(); r=baku

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 17a2436c527e (bug 1555876) for Geckoview related to mozilla::dom::IDBFactory. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249388204&repo=autoland&lineNumber=41024

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=17a2436c527efd1bfa92988a24f99c4ce86b5a0a

Backout:
https://hg.mozilla.org/integration/autoland/rev/239b2e23497f7cb3f77b1d06ee14f07c973de793

Comment 5

[(no longer active)]

Attachment: Bug 1555876 - Part 1: Return the main principal from all overrides of nsIScriptObjectPrincipal::GetEffectiveStoragePrincipal();

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a17c1ce42987
Part 1: Return the main principal from all overrides of nsIScriptObjectPrincipal::GetEffectiveStoragePrincipal(); r=baku
https://hg.mozilla.org/integration/autoland/rev/f7ebc8a45ac8
Part 2: Use storage principal in IDBFactory::CreateForMainThreadJS(); r=baku

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a17c1ce42987
https://hg.mozilla.org/mozilla-central/rev/f7ebc8a45ac8