1555899 - Keyboard navigation within awesomebar or separate search bar doesn't show focus highlight

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Asif Youssuff]

Attachment: cut.mp4

Steps to reproduce:

1. Do Ctrl l / Ctrl k
2. type something
3. press up or down on keyboard

What happens:

The autocompleted text changes as I press up and down, but the focus highlight doesn't follow what I am focusing on.

Expected result:

I should see feedback on screen as I press up and down.

192:12.14 INFO: Narrowed inbound regression window from [05535413, 2bb77ed1] (4 builds) to [2283a3e7, 2bb77ed1] (2 builds) (~1 steps left)
192:12.14 INFO: No more inbound revisions, bisection finished.
192:12.14 INFO: Last good revision: 2283a3e7f2de4a11bd7b589662dd860044faf590
192:12.14 INFO: First bad revision: 2bb77ed1fcc5ad06f91612d419160f54c09369db
192:12.14 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2283a3e7f2de4a11bd7b589662dd860044faf590&tochange=2bb77ed1fcc5ad06f91612d419160f54c09369db

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Thanks. I expect it's Wayland only, right?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Which distro/DE do you use? And can you reproduce it reliably? I'm checking it on Fedora 30 / Gnome but I don't see it.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Good, I managed to reproduce it.

Comment 4

[Asif Youssuff]

Wayland, GNOME 3.32.2 on Ubuntu 19.10 (development branch).

Comment 5

[Kate Hudson :k88hudson]

Do you think you'll be addressing this in 69 / what priority do you consider this?

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1555899 - [Wayland] Added more wayland logging, r=jhorak

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1555899 - [Wayland] Don't wait to fullscreen update as it can block forever, r=jhorak"

• Don't block all drawing until whole screen was painted, clear the screen and
  allow partial drawing instead.
• Detect window resize and allow partial drawing directly to wayland buffer in this case.
• Remove backbuffer copy - wait to buffer release instead.

Depends on D33910

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/335510024f81
[Wayland] Added more wayland logging, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/2de31fc4c99c
[Wayland] Don't wait to fullscreen update as it can block forever, r=jhorak"

Comment 9

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1555899) for Build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250679207&repo=autoland&lineNumber=21566

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2de31fc4c99cd7c0cb2ee705ce623a833df9227f

Backout:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2de31fc4c99cd7c0cb2ee705ce623a833df9227f

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c434ec2a328c
Backed out 2 changesets for Build bustage. CLOSED TREE

Comment 11

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbe0f83e6c01ca19615bedec2428f76f7948bb8f

Comment 12

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=61b7a81bc624d75984e50ebc1fc28a89c175383f

Comment 13

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecd76a7a6fa0485cb58903d8339dac709a5f2215

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0a57a5f4cc
[Wayland] Added more wayland logging, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/82dedcf5872c
[Wayland] Don't wait to fullscreen update as it can block forever, r=jhorak"

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cd0a57a5f4cc
https://hg.mozilla.org/mozilla-central/rev/82dedcf5872c