1556013 - Add prettier to the top-level eslint config

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, task)

Description

[Victor Porof [:vporof][:vp]]

This is a preliminary stop-gap before turning it on by default early July.

Everything is ignored except the debugger.

This has the advantage of allowing folks to check out what ./mach lint --fix does for them, and manually whitelist sources in the meantime if needed.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1556013 - Add prettier to the top-level eslint config, r=standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/894a44c47272
Add prettier to the top-level eslint config, r=Standard8

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/894a44c47272

Comment 4

[Kris Maglione [:kmag]]

This rule makes awful recommendations. It tells me to to do things like change:

if (some.veryLongString.ofConditional(stuff))
  return false;

to:

if (some.veryLongString.ofConditional(stuff)) return false;

Which, granted, isn't a problem for most of the tree which requires braces around conditionals, but I find code with conditionals written on a single line, particularly when they contain flow control statements, extremely hard to follow...

Comment 5

[Victor Porof [:vporof][:vp]]

We plan to continue using "curly": ["error", "all"] with eslint, which can coexist with Prettier and require braces around conditionals.