1556017 - Off-by-one-pixel error in findbar/devtools letterboxing patch

Status: RESOLVED FIXED

(Core :: Window Management, defect, P2)

Description

[Tom Ritter [:tjr]]

howaboutsynergy posted a patch at https://bugzilla.mozilla.org/show_bug.cgi?id=1546832#c25 that needs investigating and review.

Comment 1

[u636583]

fyi, iirc, findBar.length is 1 after the first time the find bar is opened, and it remains 1 even if it gets closed afterwards.

The other issue is that the +1 to devtoolsOffset isn't needed, else the size is like 1001.

both ^ are true for me anyway and I've used [1] to test, but I suppose [2] can also be used.

[1] https://www.whatismybrowser.com/detect/how-big-is-my-web-browser
[2] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html#screen

Comment 2

[Tim Huang[:timhuang]]

Thanks howaboutsynergy,

The findBar.length remains 1 after the findBar is closed since it is hidden, but not removed. And it seems there is no separator(or it is inside the iframe) for devtools iframe, so we don't need this one extra pixel according to my test.

I have a patch for this.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1556017 - Fixing the off-by-one-pixel issue of find bar and devtool iframe for Letterboxing. r?johannh!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a65d8c098c9a
Fixing the off-by-one-pixel issue of find bar and devtool iframe for Letterboxing. r=johannh

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a65d8c098c9a