Closed Bug 1556017 Opened 7 months ago Closed 6 months ago

Off-by-one-pixel error in findbar/devtools letterboxing patch

Categories

(Core :: Window Management, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: tjr, Assigned: timhuang)

References

Details

Attachments

(1 file)

fyi, iirc, findBar.length is 1 after the first time the find bar is opened, and it remains 1 even if it gets closed afterwards.

The other issue is that the +1 to devtoolsOffset isn't needed, else the size is like 1001.

both ^ are true for me anyway and I've used [1] to test, but I suppose [2] can also be used.

[1] https://www.whatismybrowser.com/detect/how-big-is-my-web-browser
[2] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html#screen

Thanks howaboutsynergy,

The findBar.length remains 1 after the findBar is closed since it is hidden, but not removed. And it seems there is no separator(or it is inside the iframe) for devtools iframe, so we don't need this one extra pixel according to my test.

I have a patch for this.

Assignee: tom → tihuang
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a65d8c098c9a
Fixing the off-by-one-pixel issue of find bar and devtool iframe for Letterboxing. r=johannh
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.