1556019 - Banned port pref doesn't seem to work

Status: VERIFIED FIXED

(Core :: Networking, defect, P2)

Description

[:Gijs (he/him)]

STR:

1. open firefox/nightly on a clean profile
2. open about:config
3. create a new string pref network.security.ports.banned, give it value 45699 (or some other random value, let's refer to it as myport)
4. open a new tab, type in localhost:myport (so localhost:45699 in our example) in the location bar and hit enter

ER:
An error with title "This address is restricted"

AR:
An error saying "Unable to connect" (assuming there's nothing running on the port you picked)

Ports that are blocked by default are blocked correctly. I don't know why the pref doesn't work.

Comment 1

[Kershaw Chang [:kershaw]]

(In reply to :Gijs (he/him) from comment #0)

STR:

1. open firefox/nightly on a clean profile
2. open about:config
3. create a new string pref network.security.banned.ports, give it value 45699 (or some other random value, let's refer to it as myport)

I think the correct pref name is network.security.ports.banned. Could you check again?

Comment 2

[:Gijs (he/him)]

(In reply to Kershaw Chang [:kershaw] from comment #1)

(In reply to :Gijs (he/him) from comment #0)

STR:

1. open firefox/nightly on a clean profile
2. open about:config
3. create a new string pref network.security.banned.ports, give it value 45699 (or some other random value, let's refer to it as myport)

I think the correct pref name is network.security.ports.banned. Could you check again?

Sorry, my steps are written wrong (will edit in a bit) but I did test this with the right pref name. I just doublechecked again and it's still broken when I use "network.security.ports.banned" . Are you not able to reproduce?

Comment 3

[Kershaw Chang [:kershaw]]

(In reply to :Gijs (he/him) from comment #2)

(In reply to Kershaw Chang [:kershaw] from comment #1)

(In reply to :Gijs (he/him) from comment #0)

STR:

1. open firefox/nightly on a clean profile
2. open about:config
3. create a new string pref network.security.banned.ports, give it value 45699 (or some other random value, let's refer to it as myport)

I think the correct pref name is network.security.ports.banned. Could you check again?

Sorry, my steps are written wrong (will edit in a bit) but I did test this with the right pref name. I just doublechecked again and it's still broken when I use "network.security.ports.banned" . Are you not able to reproduce?

I can reproduce this with the port number '45699', but I can't with the port '1234'.
I'll take a look. Thanks.

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1556019 - Use int32 to store port number

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c5bbb189ac
Use int32 to store port number r=valentin

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/26c5bbb189ac

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9070520 [details]
Bug 1556019 - Use int32 to store port number

Beta/Release Uplift Approval Request

• User impact if declined: Broken test
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes an overflow which breaks the test added by bug 1555671
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9070520 [details]
Bug 1556019 - Use int32 to store port number

approved for 68.0b10

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a0fcf2ec279d

Comment 10

[Rares Doghi, Desktop QA]

Hi, I managed to reproduce this issue in older versions of Firefox but this issue is Verified as fixed in Beta 68.0b10 as well as our latest Nightly 69.0a1 (2019-06-13).