1556023 - [about:addons] "Run in Private Windows" checkbox not updated when setting was changed elsewhere

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Rob Wu [:robwu]]

When an extension is allowed access to Private Browsing windows, the details page should reflect the new setting. There are two visual indicators:

• The purple badge on the card
• The "Run in Private Windows" input box.

The setting can be changed in two ways:

• By enabling a checkbox in the post-install doorhanger.
• By switching to a different option in the "Run in Private Windows" input box.

The visual indicators should be updated on change, but this does not always happen.

STR:

1. Enable HTML about:addons, by visiting about:config and setting extensions.htmlaboutaddons.enabled to true.
2. Install any add-on. Do not close the doorhanger yet.
3. Visit about:addons, open the Extensions list and click on the add-on card of the installed add-on.
4. Enable the checkbox at "Allow this extension to run in Private Windows" in the post-install doorhanger and click "Okay, Got it".
   (if you did accidentally close the doorhanger before, open a new about:addons tab and toggle the "Run in Private Windows" setting from there, then move back to the tab from step 3)
5. Look at the about:addons details page.

Expected:

• Both visual indicators should show that the extension may access private browsing windows.
• The "Allow" box at "Run in Private Windows" should be selected.

Actual:

• In HTML about:addons, the purple badge is updated, but the "Run in Private Windows" input box is at "Don't Allow"

( In XUL about:addons, neither visual indicator is updated when I change the setting outside of the page. We don't care that much about XUL about:addons at this point, so let's focus on the HTML about:addons )