1556034 - Fix some Calendar errors in the error console

Status: RESOLVED FIXED

(MailNews Core :: XUL Replacements, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: calendar errors.png

I'm using TB 68 and the error console looks just terrible, see enclosed.

Can all these be safely ignored?

On trunk it looks much better. So what's going on in the beta that will be the next ESR?

Comment 1

[Jorg K (CEST = GMT+2)]

On trunk I've also seen an error from the removeObserver() here:
https://searchfox.org/comm-central/rev/d3a0f4232bb7b703258d7687572f7ade075c6401/calendar/base/content/today-pane.js#65
but right now I can't reproduce it.

Comment 2

[Jorg K (CEST = GMT+2)]

There's also a lot of errors like this one:
TypeError: this.tree is null calendar-unifinder.js:486:9

I suggest you get a beta build from the tree and see for yourself.

Comment 3

[Geoff Lankow (:darktrojan)]

At least some of these are caused by the overlay loader running a second time on a document. This seems to be happening a lot in the last week or so. I think I've found a reason why.

The others I don't recognise at all, and I haven't managed to reproduce them.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1556034-repeat-overlay-1.diff

Overlays.load could be called once when readyState was loading, and then again when it changed to interactive. No idea why I'm seeing it more often recently.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9069323 [details] [diff] [review]
1556034-repeat-overlay-1.diff

Review of attachment 9069323 [details] [diff] [review]:
-----------------------------------------------------------------

I assume the loading documents would get some later?

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9069323 [details] [diff] [review]
1556034-repeat-overlay-1.diff

Not really a Calendar fix, so I'm approving this here myself.

Comment 7

[Jorg K (CEST = GMT+2)]

I'll land and uplift this, then we'll see which errors are left.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3adb373a816a
Prevent overlays from being applied when document.readyState is "loading". r=mkmelin

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/e2b462f6e540fcafa3ace677674b62111d1d69cf

We'll see into which product/component this bug should go when we're done.

Comment 10

[Jorg K (CEST = GMT+2)]

OK, some errors have disappeared from the beta, I'll let you know if I see more.

Comment 11

[Jorg K (CEST = GMT+2)]

Or let's close it and open another more specific bug for other errors.