1556109 - [socket-process] shows up as not responding in OSX activity monitor

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Nils Ohlmeier [:drno]]

When running with the socket process turned on OSX I see in the activity monitor the socket process using CPU and everything works fine. But the activity monitor highlights the process in red and with "not responding" after it's name.

We had exactly the same issue with the RDD process, which got fixed here: https://searchfox.org/mozilla-central/source/dom/media/ipc/RDDParent.cpp#122-125

But I don't know where to apply that code in the socket process.

Comment 1

[Nils Ohlmeier [:drno]]

Byron can you take a look and ask Haik (the author of the patch for RDD) and others how to get this fixed?

Comment 2

[Byron Campen [:bwc]]

I'll look into it.

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1556109: Socket process does not have a UI event loop, so disconnect from the window server.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bccd28c1a8fac64e74db153f0d2273954783d4a

Comment 5

[Byron Campen [:bwc]]

Whatever the reason, I am not able to reproduce this bug on my OS X laptop. But, I've attached a patch that should fix it, based on what we did with RDD. Nils, can you try it out?

Comment 6

[Byron Campen [:bwc]]

Try looks good.

Comment 7

[Nils Ohlmeier [:drno]]

Yes this fixes the problem locally for me.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/848ef7b322ef
Socket process does not have a UI event loop, so disconnect from the window server. r=kershaw

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/848ef7b322ef