1556201 - [Inactive CSS] Clicking on the info icon should not close the tooltip

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Victoria Wang [:victoria]]

I just absentmindedly tried to open an inactive CSS tooltip by clicking on the info icon. When this happens, the tooltip shows up for a tiny bit and then closes, and then a new property input field appears on the next line. Clicking on the icon again closes the input field but doesn't bring back the tooltip.

For now, I think the best thing to do is to remove any functionality from click actions on the icon. The tooltip should remain open when the user is hovering on the icon whether or not any click action is made.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Victoria Wang [:victoria] from comment #0)

For now, I think the best thing to do is to remove any functionality from click actions on the icon. The tooltip should remain open when the user is hovering on the icon whether or not any click action is made.

Are you sure? The standard with our tooltips is to hide them whenever you click outside the tooltip.

Comment 2

[Victoria Wang [:victoria]]

I see what you mean. I think this tooltip is different from the others which require a first click in addition to the second click to hide. In this case, there isn't more to the icon than the tooltip, so I think the two should be more connected — via hover and click (which is really just not hiding on click). (In the current situation, it especially feels odd to click on the icon and have a whole different action (new declaration) occur.)

Hovering or clicking outside the icon/tooltip should still hide the tooltip.

Comment 3

[Patrick Brosset <:pbro>]

If I understand correctly, we need to prevent anything from happening when you click on the info icon. So listen for click events on it and prevent the event from bubbling so it doesn't trigger the addition of a new declaration at the end of the rule. And also make sure the tooltip remains visible on click of the icon, as if the user was simply hovering it.

This way clicking or hovering the icon will do the same thing: the tooltip will be displayed.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1556201 - Inactive CSS: Clicking on the info icon should not close the tooltip r=jdescottes!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e7b0b9cb5f2
Inactive CSS: Clicking on the info icon should not close the tooltip r=jdescottes

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5e7b0b9cb5f2

Comment 7

[Cristian Fogel [:cfogel]]

Verified with 71.0a1 (2019-10-06) .