1556207 - Tab burst twice when open http://link from file://path/index.html

Status: RESOLVED WORKSFORME

(Core :: DOM: Content Processes, defect, P3)

Description

[Alice0775 White]

Attachment: index.html (pls save this to local file)

Loading page looks slow

Reproducible: always

Steps To reproduce:
0. Save attached html to local file system

1. Open file://path/index.html local file system
2. Click a link(http://link)
   --- observe, tab burst
3. if not, repeat step 1

Actual results:
Tab burst twice

Expected Results:
Tab burst once

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b107d251cf5b2344ceb8dfa045a90f160a55b15&tochange=9a8e4a445e0c8eee6b052576f911aa1c4d06cb02

Regressed by:
9a8e4a445e0c8eee6b052576f911aa1c4d06cb02 Nika Layzell — Bug 1528360 - Enable httpResponseProcessSelection by default r=qdot,valentin

Comment 1

[Dão Gottwald [:dao]]

Here's how tabbrowser.js triggers the animation:

  onStateChange(aWebProgress, aRequest, aStateFlags, aStatus) {
...
    } else if (aStateFlags & Ci.nsIWebProgressListener.STATE_STOP &&
               aStateFlags & Ci.nsIWebProgressListener.STATE_IS_NETWORK) {
...
        if (aWebProgress.isTopLevel && !aWebProgress.isLoadingDocument &&
            Components.isSuccessCode(aStatus) &&
...

Feel free to move this back to the tabbed browser component if the above conditions need updating.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

This appears to be caused by the way that process-switching loads are performed using HTTPResponseProcessSelection. I'm guessing that we don't notify our web progress listener that the load is resuming quickly enough, meaning that there's a small gap in the throbber animation.

We don't enable HTTPResponseProcessSelection outside of nightly currently, so I've updated the affected list to not include 68.

Marking as blocking bug 1490803 rather than bug 1562223 because the issue may persist with DocumentChannel, although the fix may look different.

Comment 4

[Michal Novotny [:michal]]

Parent process gets first start/stop notifications from child process where original HttpChannelChild was created and then again from child process where it was switched to. Once DocumentChannel is used for process switching we'll only create the final HttpChannelChild, so the first pair of notifications won't be sent (at least not from HttpChannelChild). Looks like this is either M5 or even wontfix. Or am I wrong Nika?

Comment 5

[Nika Layzell [:nika] (ni? for response)]

(In reply to Michal Novotny [:michal] from comment #4)

Parent process gets first start/stop notifications from child process where original HttpChannelChild was created and then again from child process where it was switched to. Once DocumentChannel is used for process switching we'll only create the final HttpChannelChild, so the first pair of notifications won't be sent (at least not from HttpChannelChild). Looks like this is either M5 or even wontfix. Or am I wrong Nika?

I think this is more along the lines of "will be fixed by DocumentChannel" in that case, in which case we'd keep it open until DocumentChannel has landed, and then once it's confirmed fixed we can resolve it.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch for 70 or beyond.
Since we are getting close to the end of the 69 beta cycle and this is set to P3, I'm marking it fix-optional for 69 and 70 to remove it from weekly triage.

Comment 7

[Chris Peterson [:cpeterson]]

Roll some unfixed bugs from Fission Milestone M4 to M5

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 8

[Chris Peterson [:cpeterson]]

M6

Comment 9

[Jean-Yves Avenard [:jya]]

Could please try again to see if you can still reproduce this issue?

I'm not sure what "tab burst" means, but executing the documented steps doesn't show anything weird to me.

thanks

Comment 10

[Alice0775 White]

"tab burst" means tab background animation of transparent blue color (introduced by Bug 1392157).

Anyway, the problem is no longer reproduced on Nightly72.0a1.