1556231 - Default bookmark to AMO ("Firefox: Customise with add-ons") in Android is broken

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[plaice.adam+persona]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

(Re-)install Firefox for Android nightly.

Go to the bookmarks panel in a new tab.

Click on the "Firefox: Customise with add-ons" link:

https://addons.mozilla.org/android?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

Actual results:

You're redirected to a "Oops! We can’t find that page" page:

https://addons.mozilla.org/en-GB/firefox/android/?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

(or en-US etc. depending on your localisation)

Expected results:

You should be redirected to:

https://addons.mozilla.org/en-GB/android/?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

which is a landing page for Webextensions for Firefox for Android.

The bug was introduced by a change on AMO's side:

https://github.com/mozilla/addons-frontend/issues/8059

and, is apparently (?) due to AMO previously "filling in" an extra slash (/), but not doing so any longer.

I have no idea whether fixing this on AMO's side is easy or not (depending on how the parsing/redirecting code works), but it can at least be easily fixed for new Firefox for Android users by adding a slash — i.e. changing the URL from:

https://addons.mozilla.org/android?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

to

https://addons.mozilla.org/android/?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

The relevant source is:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/strings.xml.in#496

Comment 1

[Eliza Balazs]

Hi!

I tested this on Nightly 68.0a1 (2019-06-01), Beta 68.0b5, Release 67.0 with OnePlus 5T (Android 9), Nexus 6P (8.1.0), Huawei Honor 8 (Android 7.0) and I can reproduce the issue following the steps:

1. Launch Fennec and go to the Bookmarks panel;
2. Tap on the "Firefox: Customize with add-ons" default bookmark.

Expected result:
The Firefox Add-ons page opens.

Actual result:
The Firefox Add-ons page opens with a "Oops! We can't find the page" message displayed.

Thanks!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:st3fan, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[plaice.adam+persona]

The issue appears to have been resolved on the AMO side — the link now resolves correctly (on all three versions of Firefox for Android).