1556273 - Harden ABI checks against bogus __anonymous_enum__ errors

Status: RESOLVED FIXED

(NSS :: Test, enhancement, P1)

Description

[Martin Thomson [:mt:]]

We've seen a couple of recent errors like this:

FAILED: there are new unexpected ABI changes
--- /home/worker/nss/automation/abi-check/expected-report-libnss3.so.txt	2019-06-01 21:13:30.113442000 +0000
+++ /home/worker/nss/automation/abi-check/new-report-libnss3.so.txt	2019-06-01 21:14:56.950898000 +0000
@@ -7,15 +7,15 @@
 
   [C]'function SECStatus CERT_AddOCSPAcceptableResponses(CERTOCSPRequest*, SECOidTag, ...)' at ocsp.c:2203:1 has some indirect sub-type changes:
     parameter 2 of type 'typedef SECOidTag' has sub-type changes:
-      underlying type 'enum __anonymous_enum__' at secoidt.h:34:1 changed:
+      underlying type 'enum __anonymous_enum__3' at secoidt.h:34:1 changed:
         type size hasn't changed
         3 enumerator insertions:
-          '__anonymous_enum__::SEC_OID_EXT_KEY_USAGE_IPSEC_END' value '361'
-          '__anonymous_enum__::SEC_OID_EXT_KEY_USAGE_IPSEC_TUNNEL' value '362'
-          '__anonymous_enum__::SEC_OID_EXT_KEY_USAGE_IPSEC_USER' value '363'
+          '__anonymous_enum__3::SEC_OID_EXT_KEY_USAGE_IPSEC_END' value '361'
+          '__anonymous_enum__3::SEC_OID_EXT_KEY_USAGE_IPSEC_TUNNEL' value '362'
+          '__anonymous_enum__3::SEC_OID_EXT_KEY_USAGE_IPSEC_USER' value '363'
 
         1 enumerator change:
-          '__anonymous_enum__::SEC_OID_TOTAL' from value '361' to '364' at secoidt.h:34:1
+          '__anonymous_enum__3::SEC_OID_TOTAL' from value '361' to '364' at secoidt.h:34:1

I don't really know whether this is a change in libabigail, the compiler, or our code, but there is no sense in being too pedantic here. As long as the names of the fields are the same, the name of an anonymous enum is irrelevant. We can (and should) scrub the checks for these. I plan to use sed -e 's/__anonymous_enum__[0-9]*::/__anonymous_enum__::/g'.

I am also tempted to scrub all instances of line numbers, but I'm not confident that these are always irrelevant.

Comment 1

[Martin Thomson [:mt:]]

Attachment: Bug 1556273 - Scrub __anonymous_enum__ in ABI checks, r?jcj

This probably isn't ideal, but it should avoid problems with numbering of
anonymous enumerations.

Comment 2

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1556273 - Scrub __anonymous_enum__ from branch 3.44 ABI checks r?mt

Comment 3

[Intermittent Failures Robot]

2 failures in 5197 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• nss: 2

Platform breakdown:

• nss-tools: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556273&startday=2019-06-03&endday=2019-06-09&tree=all

Comment 4

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/3e9feaefe710e6ded945d28af8f873dd5255fbe9

Comment 5

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/a646666e8666b3b83fc6978b9bae9d9d1cacfd62

Comment 6

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/96c8c580cc096e805fe9399b96da39da1e82734f