1556282 - Reliably-failing /css/css-contain/contain-layout-button-001.html | Testing http://web-platform.test:8000/css/css-contain/contain-layout-button-001.html == http://web-platform.test:8000/css/css-contain/reference/contain-layout-button-001-ref.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=249637132&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/T-usPOVvQoyEebc9DJsooA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/T-usPOVvQoyEebc9DJsooA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2019-06-02T23:20:53.550Z] 23:20:53 INFO - TEST-START | /css/css-contain/contain-layout-button-001.html
[task 2019-06-02T23:20:54.117Z] 23:20:54 INFO - TEST-UNEXPECTED-FAIL | /css/css-contain/contain-layout-button-001.html | Testing http://web-platform.test:8000/css/css-contain/contain-layout-button-001.html == http://web-platform.test:8000/css/css-contain/reference/contain-layout-button-001-ref.html
[task 2019-06-02T23:20:54.118Z] 23:20:54 INFO - REFTEST IMAGE 1

Comment 1

[Intermittent Failures Robot]

2 failures in 4337 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform breakdown:

• android-em-7-0-x86: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556282&startday=2019-05-27&endday=2019-06-02&tree=all

Comment 2

[Intermittent Failures Robot]

20 failures in 1101 pushes (0.018 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 20

Platform breakdown:

• android-em-7-0-x86_64: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556282&startday=2019-06-06&endday=2019-06-06&tree=all

Comment 3

[Intermittent Failures Robot]

30 failures in 5197 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 30

Platform breakdown:

• android-em-7-0-x86_64: 30

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556282&startday=2019-06-03&endday=2019-06-09&tree=all

Comment 4

[Daniel Holbert [:dholbert]]

This failure is happening because we render buttons on Android with curved corners, even when a custom border has been specified. The reference case uses a div rather than a button, so it does not have those curved corners.

I recall running into this with other test failures before.

There may be a way to adjust the test to avoid this issue, but for now we could also just mark this test as fuzzy, since not very many pixels are differing.

Comment 5

[Daniel Holbert [:dholbert]]

Yeah, we should annotate this test as fuzzy, with a link to bug 1484841 as the reason for the fuzziness.

(technically it's not so much "fuzzy" but rather "a few pixels do actually differ due to our Android button rendering weirdness described in bug 1484841". But we can abuse fuzzy for this purpose in any case.)

Comment 6

[Daniel Holbert [:dholbert]]

The logcat log for the test failure in comment 0 says:

Found 12 pixels different, maximum difference per channel 191

I'll use that to craft a fuzzy annotation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aad99a661149
Annotate contain-layout-button-001.html as fuzzy rather than failing, on Android. (no review, test annotation only)

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/aad99a661149