1556352 - Custom elements: implement custom element reaction's formAssociatedCallback

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[John Dai[:jdai]]

Spec:
https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-reactions

Comment 1

[Edgar Chen [:edgar]]

I would like to refactor and clean up custom element callbacks a bit in this bug.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 1: Merge WebComponents.webidl into CustomElementRegistry.webidl; r=smaug

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 2: Remove unnecessary includes from CustomElementRegistry.h; r=smaug

Depends on D129139

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 3: Merge LifecycleCallback*Args; r=smaug

To make adding new callback a bit easiler.

Depends on D129169

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 4: Move CustomElementCallback declaration out of CustomElementRegistry.h; r=smaug

Depends on D129190

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 2: Implement formAssociatedCallback; r=smaug

Depends on D129191

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7ddca4f2b3cb208f4e768a37b09c47e834a6052

Comment 8

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe19068d282013e335efe20b2c0658336acf72dc

Comment 9

[Edgar Chen [:edgar]]

We need the refactor/cleanup part to add a new callback, but there are still more things I would need to consider to hook the formAssociated callback. So I am going to move the refactor/cleanup part to bug 1556354 which is simpler to implement, in order to not block other callback implementations, e.g. bug 1556363.

Comment 10

[Phabricator Automation]

Comment on attachment 9247052 [details]
Bug 1556352 - Part 1: Merge WebComponents.webidl into CustomElementRegistry.webidl; r=smaug

Revision D129139 was moved to bug 1556354. Setting attachment 9247052 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9247101 [details]
Bug 1556352 - Part 2: Remove unnecessary includes from CustomElementRegistry.h; r=smaug

Revision D129169 was moved to bug 1556354. Setting attachment 9247101 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9247145 [details]
Bug 1556352 - Part 3: Merge LifecycleCallback*Args; r=smaug

Revision D129190 was moved to bug 1556354. Setting attachment 9247145 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9247146 [details]
Bug 1556352 - Part 4: Move CustomElementCallback declaration out of CustomElementRegistry.h; r=smaug

Revision D129191 was moved to bug 1556354. Setting attachment 9247146 [details] to obsolete.

Comment 14

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 1: Do not set form owner from parser for form-associated custom element; r=smaug

See steps 14 of https://html.spec.whatwg.org/commit-snapshots/3ad5159be8f27e110a70cefadcb50fc45ec21b05/#create-an-element-for-the-token

From spec perspective, FACE needs this in order to enqueue the formAssociated callback
while FACE is inserted into document. Otherwise it would bail out in
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#association-of-controls-and-forms:parser-inserted-flag,
and wouldn't run https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#reset-the-form-owner
steps nor https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-reactions:reset-the-form-owner

From implementation perspective, we don't implement parser inserted flag, but we do
update the form owner from parser. Not doing this would make the subsequent part
which implements formAssociated callback a bit simpler, where we don't need to consider
or handle the case that form owner is set from parser.

Comment 15

[Edgar Chen [:edgar]]

Attachment: Bug 1556352 - Part 3: Add wpt test for updating id attribute of form element; r=smaug

Depends on D129197

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee2b69cb286c
Part 1: Do not set form owner from parser for form-associated custom element; r=smaug
https://hg.mozilla.org/integration/autoland/rev/ee3956242401
Part 2: Implement formAssociatedCallback; r=smaug
https://hg.mozilla.org/integration/autoland/rev/f423533b66a9
Part 3: Add wpt test for updating id attribute of form element; r=smaug

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31416 for changes under testing/web-platform/tests

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee2b69cb286c
https://hg.mozilla.org/mozilla-central/rev/ee3956242401
https://hg.mozilla.org/mozilla-central/rev/f423533b66a9

Comment 19

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot