1556364 - Custom elements: implement setValidity() for ElementInternals

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[John Dai[:jdai]]

Spec:
https://html.spec.whatwg.org/#definitions

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1556364 - Part 1: Implement validity attribute of ElementInternals; r=smaug

Depends on D129329

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1556364 - Part 2-2: Implement validationMessage attribute of ElementInternals; r=smaug

Depends on D129810

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1556364 - Part 3: Implement setValidity() of ElementInternals; r=smaug

Depends on D129811

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1556364 - Part 4: Support updating valid/invalid state on form-associated custom elements; r=smaug

Depends on D129821

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1556364 - Part 2-1: Split nsGenericHTMLFormControlElement-only members from nsIConstraintValidation to a separated class; r=smaug

Depends on D129810

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1466ff64ce79ffb90d86ecde91bb2cc8f997c114

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c8c74e99e47
Part 1: Implement validity attribute of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/c77ef41d43d4
Part 2-1: Split nsGenericHTMLFormControlElement-only members from nsIConstraintValidation to a separated class; r=smaug
https://hg.mozilla.org/integration/autoland/rev/f6f7f949551f
Part 2-2: Implement validationMessage attribute of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/76fc30f27c39
Part 3: Implement setValidity() of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/dabffbe71a31
Part 4: Support updating valid/invalid state on form-associated custom elements; r=smaug

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31751 for changes under testing/web-platform/tests

Comment 9

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1556364) for causing web-platform test failures.
Backout link
Push with failures
Failure Log

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/422457edff03
Backed out 5 changesets for causing web-platform test failures. CLOSED TREE

Comment 12

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=ef7448ac0776819d9c71d319461f9c741d2d2fd6

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbb09af22060
Part 1: Implement validity attribute of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/6aeefd8d3049
Part 2-1: Split nsGenericHTMLFormControlElement-only members from nsIConstraintValidation to a separated class; r=smaug
https://hg.mozilla.org/integration/autoland/rev/8fb29eb57f78
Part 2-2: Implement validationMessage attribute of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/77962d21620f
Part 3: Implement setValidity() of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2e5fbe135bac
Part 4: Support updating valid/invalid state on form-associated custom elements; r=smaug

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dbb09af22060
https://hg.mozilla.org/mozilla-central/rev/6aeefd8d3049
https://hg.mozilla.org/mozilla-central/rev/8fb29eb57f78
https://hg.mozilla.org/mozilla-central/rev/77962d21620f
https://hg.mozilla.org/mozilla-central/rev/2e5fbe135bac

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 19

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbb09af22060
Part 1: Implement validity attribute of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/6aeefd8d3049
Part 2-1: Split nsGenericHTMLFormControlElement-only members from
nsIConstraintValidation to a separated class; r=smaug
https://hg.mozilla.org/integration/autoland/rev/8fb29eb57f78
Part 2-2: Implement validationMessage attribute of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/77962d21620f
Part 3: Implement setValidity() of ElementInternals; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2e5fbe135bac
Part 4: Support updating valid/invalid state on form-associated custom
elements; r=smaug

== Change summary for alert #32555 (as of Mon, 29 Nov 2021 09:48:03 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
18%	perf_reftest_singletons link-style-cache-1.html	macosx1015-64-shippable-qr	e10s stylo webrender	354.05 -> 291.05
16%	perf_reftest_singletons link-style-cache-1.html	macosx1015-64-shippable-qr	e10s stylo webrender	355.88 -> 299.11
12%	perf_reftest_singletons inline-style-cache-1.html	macosx1015-64-shippable-qr	e10s stylo webrender	1,058.36 -> 934.55

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32555