1556393 - Enable Prettier when running format-source

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1556393 - hgext: Enable Prettier when running format-source, r=sheehan,andi

Depends on D33461

Comment 2

[Connor Sheehan [:sheehan]]

Sylvestre, should we re-enable format-source for this bug? Your team recently disabled it so I'd like to make sure this bug aligns with future plans for global tree re-formats.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Yeah, this is coordinated with Victor. Thanks for asking :)

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Connor Sheehan [:sheehan] from comment #2)

Sylvestre, should we re-enable format-source for this bug? Your team recently disabled it so I'd like to make sure this bug aligns with future plans for global tree re-formats.

There's two patches waiting for you in phab!
https://phabricator.services.mozilla.com/D33491
https://phabricator.services.mozilla.com/D33461

Comment 5

[Connor Sheehan [:sheehan]]

(In reply to Victor Porof [:vporof][:vp] from comment #4)

(In reply to Connor Sheehan [:sheehan] from comment #2)

Sylvestre, should we re-enable format-source for this bug? Your team recently disabled it so I'd like to make sure this bug aligns with future plans for global tree re-formats.

There's two patches waiting for you in phab!
https://phabricator.services.mozilla.com/D33491
https://phabricator.services.mozilla.com/D33461

Left a review and a comment on each of those, respectively.

Sorry for taking so long to look at them!

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1556393 - Pre 1 (m-c): Update .hg-format-source to use Prettier when running format-source, r=andi

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1556393 - Pre 0 (m-c): Create a simple Prettier command for running format-source, r=andi

Depends on D36719

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/60169d9efd0d
Pre 0 (m-c): Create a simple Prettier command for running format-source, r=andi
https://hg.mozilla.org/mozilla-central/rev/fa87fa78124e
Pre 1 (m-c): Update .hg-format-source to use Prettier when running format-source, r=andi, CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/57ff6e1a400b
hgext: Enable Prettier when running format-source, r=sheehan,andi