1556396 - prevent storing favicons for unsupported protocols

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P3)

Description

[Marco Bonardo [:mak]]

Looking at some favicons.sqlite dbs, I noticed a bunch of icons assigned to about: and file: urls, that should not be necessary, and are very likely bogus.
The about icons may be result of our "smart" assignment of icons to bookmarks. file:// icons should not be stored, afaict (TBD)

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: Bug 1556396 - Prevent icons assigned to non-http(s) page URLs from being saved to db. r?mak

Comment 2

[Marco Bonardo [:mak]]

Rethinking about it, there's existing use cases to store favicons for about or file pages.
For example a user may save websites and then bookmark the file: URL, then use the icons to more easily distinguish bookmarks.
So let's convert this into a defensive mechanism where we only allow storing icons for http, http, file, about.

Comment 3

[Yazan Al Macki [:yazan]]

Attachment: Bug 1556396 - Prevent icons assigned to unsupported protocol page URLs from being saved to db. r?mak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4ed5a7724f9
Prevent icons assigned to unsupported protocol page URLs from being saved to db. r=mak,places-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b4ed5a7724f9