1556414 - Hebrew characters displayed in reverse order when using shadow DOM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[adir.developer]

Attachment: custom-element bug.html

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

Create a custom element that displays a text with Hebrew characters.
Use the custom element in a page without any Hebrew character.

Note:
This reproduces only when the page does not contain any Hebrew character (should not be even as a comment).

See attached file.

Actual results:

The Hebrew characters displayed in reversed order (left to right).

Expected results:

The Hebrew characters should be displayed from right to left.

Comment 1

[adir.developer]

More technical info: (where the bug reproduce)
User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Comment 2

[Edgar Chen [:edgar]]

Hi John, could you take a look if this is something related to custom element?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This is about shadow DOM

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

The whole directionality inside shadow DOM is still undefined
https://github.com/whatwg/html/issues/3699

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/dom/base/CharacterData.cpp#229,309 looks fine, but I guess there is some other case. https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/dom/base/CharacterData.cpp#454,456-460

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1556414, mark document having bidi also when bidi is only in shadow DOM, r=edgar

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06f834fce85
mark document having bidi also when bidi is only in shadow DOM, r=edgar

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c06f834fce85