1556485 - Firefox sidebar should respect icon context fill

Status: RESOLVED WORKSFORME

(WebExtensions :: Frontend, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: sidebar.png

STEPS TO REPRODUCE
Enable dark theme
Install Notes add-on
Customize Notes icon into the toolbar
Open sidebar

EXPECTED RESULTS
Notes icon in sidebar switcher is light like it is in the toolbar

ACTUAL RESULTS
Icon is dark on dark

Comment 1

[Rob Wu [:robwu]]

This is not a bug in Firefox. The Notes add-on (version 4.3.5) uses icons/notes.svg as the sidebar_action.default_icon. This is an image without context-fill. The browser_action icon uses icons/notes-fill.svg, which does have context-fill. When I update the icon, by opening a debugger via about:debugging and running browser.sidebarAction.setIcon({path: "icons/notes-fill.svg"});, then the expected result is shown.

Although context-fill seems to work, this is probably not what we want to support in the long term, as previously we decided against using context-fill for customizing extension components in the browser UI (bug 1391980). context-fill only works for Mozilla extensions (by bug 1377302).

Third-party add-ons cannot easily set icons for a specific theme (unless they use the theme API to detect the current theme, and dynamically set the icon with sidebarAction.setIcon or pageAction.setIcon). I filed bug 1558587 to fill this gap.