Closed Bug 1556533 Opened 5 years ago Closed 5 years ago

RDM simulates orientationchange event when the page is refreshed.

Categories

(DevTools :: Responsive Design Mode, defect, P1)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mtigley, Assigned: mtigley)

Details

(Whiteboard: [rdm-reserve])

Attachments

(1 file)

Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed.
47 bytes, text/x-phabricator-request
Details | Review

STR

  1. Go to: https://bug1509255.bmoattachments.org/attachment.cgi?id=9026900
  2. Open RDM.
  3. Refresh the page.

ER:
No alert dialogue should have opened.

AR:
The alert dialogue saying "the orientation of the device is now 0" is displayed. This is because the orientationchange event is being dispatched when the page is being refreshed. This is not supposed to happen.

Assignee: nobody → mtigley
Priority: -- → P1
Status: NEW → ASSIGNED
Whiteboard: [rdm-reserve]
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91643c6f9a42
Fix RDM simulating orientationchange event when the page is refreshed. r=gl
Backout by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e91118e15bb5
Backed out changeset 91643c6f9a42 for es lint failure CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=91643c6f9a42b80a9e63db58931f8b4be8c6e69b&searchStr=linting%2Copt%2Csource-test-mozlint-eslint%2C%28es%29&tochange=e91118e15bb536747f66ce37a98a2b87ccf722c4&selectedJob=250462729

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250462729&repo=autoland&lineNumber=233

[task 2019-06-06T21:03:38.726Z] building 'psutil._psutil_posix' extension
[task 2019-06-06T21:03:38.726Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-06-06T21:03:38.726Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-06-06T21:03:38.726Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-06-06T21:03:38.726Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-06-06T21:03:38.726Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-06-06T21:03:38.726Z]
[task 2019-06-06T21:03:38.726Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-06-06T21:11:27.053Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/responsive.html/actions/devices.js:25:41 | 'changeViewportAngle' is assigned a value but never used. (no-unused-vars)
[task 2019-06-06T21:11:27.053Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/responsive.html/components/App.js:9:7 | 'Services' is assigned a value but never used. (no-unused-vars)
[taskcluster 2019-06-06 21:11:27.439Z] === Task Finished ===
[taskcluster 2019-06-06 21:11:28.266Z] Unsuccessful task run with exit code: 1 completed in 712.472 seconds

Flags: needinfo?(mtigley)
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4ea30c29aa7
Fix RDM simulating orientationchange event when the page is refreshed. r=gl

Backed out changeset f4ea30c29aa7 (Bug 1556533) for browser_orientationchange_event.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f4ea30c29aa78e70ee1596638d08e8e3146700c9&tochange=aae7e4d626d364f3a02bcd2ce3c9ad4b4723ac45&selectedJob=250524045

Backout link: https://hg.mozilla.org/integration/autoland/rev/aae7e4d626d364f3a02bcd2ce3c9ad4b4723ac45

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250524045&repo=autoland&lineNumber=7841

[task 2019-06-07T01:18:11.349Z] 01:18:11 INFO - TEST-START | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js
[task 2019-06-07T01:18:11.365Z] 01:18:11 INFO - Entering test bound
[task 2019-06-07T01:18:11.365Z] 01:18:11 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,
[task 2019-06-07T01:18:11.482Z] 01:18:11 INFO - Tab added and finished loading
[task 2019-06-07T01:18:11.486Z] 01:18:11 INFO - Opening responsive design mode
[task 2019-06-07T01:18:11.790Z] 01:18:11 INFO - GECKO(1987) | console.log: "[DISPATCH] action type:" "CHANGE_DISPLAY_PIXEL_RATIO"
[task 2019-06-07T01:18:11.794Z] 01:18:11 INFO - GECKO(1987) | console.log: "[DISPATCH] action type:" "ADD_VIEWPORT"
[task 2019-06-07T01:18:11.983Z] 01:18:11 INFO - GECKO(1987) | JavaScript error: chrome://global/content/browser-child.js, line 15: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface]
[task 2019-06-07T01:18:11.983Z] 01:18:11 INFO - GECKO(1987) | JavaScript error: chrome://global/content/elements/browser-custom-element.js, line 1134: uncaught exception: 2147500033
[task 2019-06-07T01:18:11.991Z] 01:18:11 INFO - GECKO(1987) | JavaScript error: chrome://global/content/browser-child.js, line 15: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface]
[task 2019-06-07T01:18:11.991Z] 01:18:11 INFO - GECKO(1987) | JavaScript error: chrome://global/content/elements/browser-custom-element.js, line 1134: uncaught exception: 2147500033
[task 2019-06-07T01:18:12.040Z] 01:18:12 INFO - Console message: [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface]" {file: "chrome://global/content/browser-child.js" line: 15}]
[task 2019-06-07T01:18:12.040Z] 01:18:12 INFO - Console message: [JavaScript Error: "uncaught exception: 2147500033" {file: "chrome://global/content/elements/browser-custom-element.js" line: 1134}]
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - Console message: [JavaScript Error: "[Exception... "Method not implemented'Method not implemented' when calling method: [nsIWebNavigation::sessionHistory]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: chrome://global/content/elements/browser-custom-element.js :: construct :: line 1134" data: no]"]
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - construct@chrome://global/content/elements/browser-custom-element.js:1134:11
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - attributeChangedCallback@chrome://global/content/elements/browser-custom-element.js:41:12
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - start@resource://devtools/client/responsive.html/browser/tunnel.js:175:13
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - start@resource://devtools/client/responsive.html/browser/swap.js:247:20
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - asyncinit@resource://devtools/client/responsive.html/manager.js:354:21
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - ResponsiveUI@resource://devtools/client/responsive.html/manager.js:279:22
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - openIfNeeded@resource://devtools/client/responsive.html/manager.js:98:18
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - openRDM@chrome://mochitests/content/browser/devtools/client/responsive.html/test/browser/head.js:84:28
[task 2019-06-07T01:18:12.041Z] 01:18:12 INFO - addRDMTask/<@chrome://mochitests/content/browser/devtools/client/responsive.html/test/browser/head.js:113:27
[task 2019-06-07T01:18:12.042Z] 01:18:12 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1115:34
[task 2019-06-07T01:18:12.042Z] 01:18:12 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1143:12
[task 2019-06-07T01:18:12.042Z] 01:18:12 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1004:14
[task 2019-06-07T01:18:12.042Z] 01:18:12 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2019-06-07T01:18:12.042Z] 01:18:12 INFO -
[task 2019-06-07T01:18:12.042Z] 01:18:12 INFO - Console message: [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface]" {file: "chrome://global/content/browser-child.js" line: 15}]
...
[task 2019-06-07T01:18:12.398Z] 01:18:12 INFO - GECKO(1987) | console.log: "[DISPATCH] action type:" "ROTATE_VIEWPORT"
[task 2019-06-07T01:18:12.435Z] 01:18:12 INFO - Check the original orientation values before the orientationchange
[task 2019-06-07T01:18:12.435Z] 01:18:12 INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | Primary orientation type is portrait-primary. - "portrait-primary" == "portrait-primary" -
[task 2019-06-07T01:18:12.435Z] 01:18:12 INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | Original angle is set at 0 degrees - 0 == 0 -
[task 2019-06-07T01:18:12.471Z] 01:18:12 INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | 'orientationchange' event fired - true == true -
[task 2019-06-07T01:18:12.472Z] 01:18:12 INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | Orientation state was updated to landscape-primary - "landscape-primary" == "landscape-primary" -
[task 2019-06-07T01:18:12.473Z] 01:18:12 INFO - TEST-INFO | started process screentopng
[task 2019-06-07T01:18:12.834Z] 01:18:12 INFO - TEST-INFO | screentopng: exit 0
[task 2019-06-07T01:18:12.834Z] 01:18:12 INFO - TEST-UNEXPECTED-FAIL | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | Orientation angle was updated to 90 degrees. - 0 == 90 -
[task 2019-06-07T01:18:12.834Z] 01:18:12 INFO - Stack trace:
[task 2019-06-07T01:18:12.835Z] 01:18:12 INFO - resource://testing-common/content-task.js line 59 > eval:orientationChange</<:15
[task 2019-06-07T01:18:12.836Z] 01:18:12 INFO - resource://devtools/server/actors/emulation.js:simulateScreenOrientationChange:389
[task 2019-06-07T01:18:12.836Z] 01:18:12 INFO - resource://devtools/shared/protocol.js:handler:1189
[task 2019-06-07T01:18:12.837Z] 01:18:12 INFO - resource://devtools/server/main.js:onPacket:1291
[task 2019-06-07T01:18:12.837Z] 01:18:12 INFO - resource://devtools/shared/transport/child-transport.js:receiveMessage:66
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Check that the viewport orientation changed, but not the angle after a reload
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Waiting for event: 'only-viewport-orientation-changed' on [object Object].
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Got event: 'only-viewport-orientation-changed' on [object Object].
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | orientationchange event was not dispatched on reload. -
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Check that we still have the previous orientation values.
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - TEST-UNEXPECTED-FAIL | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | Orientation angle is still 90 - 0 == 90 -
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Stack trace:
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - resource://testing-common/content-task.js line 59 > eval:null:5
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - resource://testing-common/content-task.js:null:60
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_orientationchange_event.js | Orientation is still landscape-primary. - "landscape-primary" == "landscape-primary" -
[task 2019-06-07T01:18:12.843Z] 01:18:12 INFO - Closing responsive design mode

Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/752a2894ca73
Fix RDM simulating orientationchange event when the page is refreshed. r=gl

https://hg.mozilla.org/mozilla-central/rev/752a2894ca73

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
QA Whiteboard: [qa-69b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: