Closed Bug 1556585 Opened 5 years ago Closed 5 years ago

Convert Settings icon on new tab page to use fluent

Categories

(Firefox :: New Tab Page, task, P1)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 69
Iteration:
69.3 - Jun 10 - 23
Tracking Flags:
Tracking Status
firefox69 --- verified

People

(Reporter: pdahiya, Assigned: jcarlos)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5089
52 bytes, text/x-github-pull-request
Details | Review

Scope of this bug is to convert below string in new tab codebase to use fluent

settings_pane_button_label=Customize your New Tab page

Assignee: nobody → volbohel
Iteration: --- → 69.2 - May 27 - Jun 9
Priority: -- → P1
Iteration: 69.2 - May 27 - Jun 9 → 69.3 - Jun 10 - 23
Type: defect → task
Blocks: 1561811
Keywords: github-merged

https://hg.mozilla.org/mozilla-central/rev/885c1d54bcb9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Component: Activity Streams: Newtab → New Tab Page

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190630214222) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now the <button class="icon icon-settings" data-l10n-id="newtab-settings-button" title="Customize your New Tab page"></button> string is displayed if we inspect the "Customize your New Tab page" button.

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: