1556658 - The Website link from the Lockwise manage page can't be opened using middle click

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: link middle click.gif

[Affected Versions]:

• Lockwise 2.2.3-alpha
• Nightly 68.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Perquisites]

• Have the Firefox 68 beta or latest Nightly 69 version installed.
• Have the Lockwise 2.2.3 - alpha extension installed from Lockwise website.
• Have multiple saved logins.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Click the "Lockwise" toolbar button and click the "Open Lockwise" button from the doorhanger.
3. Click one of the saved logins from the manage page.
4. Middle click on the website link.
5. Observe the behavior.

[Expected results]:

• The website is opened in a new tab.

[Actual results]:

• Nothing happens.

[Regression]:

• This issue is not reproducible on Firefox versions lower than 68. Considering this using mozregression tools I have managed to find the pushlog with the changes that caused this regression.
• Here is the pushlog: https://tinyurl.com/y6kndlly
• It seems that bug 1379466 introduced this issue on Firefox 68.

[Notes]:

• The issue is not reproducible on Firefox 67 release.
• The issue is also reproducible if you try to open the website by pressing the "Ctrl" key + "Left Click". The website is not opened.
• The issue is also logged in Lockwsie Github repository in #255.
• Attached a screen recording with the issue.

Comment 1

[Devin Reams]

Thanks, Cosmin. Unless this is deemed an issue (inconsistent or unexpected behavior with blocked popups) and resolved upstream in Forefox, then we don’t expect to make changes to fix this on the Lockwise addon.

Therefore, I’ll close this as “wontfix” for now unless someone wants to re-purpose the bug for the broader potential “regression”.

Comment 2

[Cosmin Muntean [:cmuntean], Ecosystem QA]

This regression is also reproducible on "about:logins" page on the latest Nightly 70.0a1 build. In order to reproduce the issue please follow the next STR:

[Prerequsites]:

• Have at least one password saved in the browser.

[Steps to Reproduce]

1. Open the latest Nightly 70.0a1 build and navigate to "about:logins" page.
2. Click one of the saved logins.
3. Middle click on the website link of the selected login.
4. Observe the behavior.

[Expected results]:

• The website is opened in a new tab.

[Actual results]:

• Nothing happens.

Considering that this regression affects "about:logins" page, I will reopen the issue.

Comment 3

[Matthew N. [:MattN]]

Morphing this to track desktop about:logins.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1556658 - Middle-clicking on the origin should open the link. r?MattN

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f529de132f
Middle-clicking on the origin should open the link. r=MattN

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/24f529de132f

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 70.0a1 (2019-08-29) (64-bit) on Windows 7 c64, MacOS 10.14 and Arch Linux 4.12.

• The Website link can be successfully opened using middle click.