1556709 - [css-sizing] wrong intrinsic size with white-space:nowrap and trailing white-space

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[Cameron McCormack (:heycam)]

Attachment: screen shot

See the screen shot.

2:48.09 INFO: First bad revision: 750046b87c63930678adff852290f1b1f76b534c
2:48.09 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d6e4e46dde44d7745040216569ed81546fb450d3&tochange=750046b87c63930678adff852290f1b1f76b534c

Comment 1

[Jonathan Kew [:jfkthame]]

Ugh - I was just going to report this, and found it already filed.

I think the problem is https://dxr.mozilla.org/mozilla-central/rev/c909c105f914f69054b9a7c6b189ee39fa1cad44/layout/generic/nsBlockFrame.cpp#779-781. We probably need to guard this with some additional style checks -- e.g. we shouldn't do it if white-space:nowrap is in effect.

Comment 3

[Mats Palmgren (inactive)]

Bah, I thought OptionallyBreak() would deal with that somehow, but I forgot to check...
(amazing that we have zero tests for this :-))

Comment 4

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3043f084685a876837d4983fa3b488499a607ef7

Comment 5

[Mats Palmgren (inactive)]

Attachment: Bug 1556709 - Only call OptionallyBreak() if we may break at white-space. r=jfkthame

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a63f3c0ef6
Only call OptionallyBreak() if we may break at white-space.  r=jfkthame

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17199 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d4a63f3c0ef6

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 13

[Kohei Yoshino [:kohei]]

Verified fixed with Nightly today. Thank you!