1556807 - wpt wasm\jsapi\constructor\instantiate.any.js fails in some configurations

Status: NEW

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[James Graham [:jgraham]]

I'm having to disable this on import to avoid permafails, since I don't think I have any way to set different expectations for different SM configurations (this is a problem).

See https://treeherder.mozilla.org/#/jobs?repo=try&collapsedPushes=449972&selectedJob=248927636&revision=8d93b0211384785fe162e10ebe8c9ffe6ebf6b88

Comment 1

[Lars T Hansen [:lth]]

The log for the old run is inaccessible. Trying to explore this again in https://treeherder.mozilla.org/#/jobs?repo=try&revision=513ee633fab29c07cacc3424236d5e30d7c0e75b but we'll see.

Comment 2

[Lars T Hansen [:lth]]

I guess I don't understand what the problem is here. I see that there are failing tests, but I have no clue why they are failing or what the spidermonkey configuration has to do with it. I have a vanilla debug build on Linux, and I see the failures locally, but the harness does not indicate what fails.

Comment 3

[James Graham [:jgraham]]

Hmm, I don't know much about the jstests.py output, but you could try running with --log-wptreport wptreport.json which should produce an output file containing any error message. Locally ./jstests.py --wpt enabled --log-wptreport wptreport.json ../build_DBG.OBJ/dist/bin/js wasm/jsapi/constructor/instantiate.any.js passes for me after re-enabling the test (side note: is there a better way to run these tests locally without having to manage the virtualenv by hand?).

Comment 4

[Lars T Hansen [:lth]]

I don't know much about how to run these, so I ended up hacking js/src/build-debug/js/src/Makefile to pass explicit arguments to the test runner so that I could run make check-jstests in js/src/build-debug. And then I do see failures after marking the test as passing in the metafile, but the log output in the console is no more helpful than in the log on treeherder.

Annoyingly I could not get this to run with jstests.py directly because it was complaining about some missing python hg library, presumably what you allude to in your remark about virtualenv (which is something I don't know how to manipulate at all).

I'll see if I can get some logging output as you suggest.

Comment 5

[James Graham [:jgraham]]

FWIW the way I enable the Python env is something like
jgraham@ginny:~/develop/gecko/js/src/tests$ source ../build_OPT.OBJ/_virtualenvs/init/bin/activate

It really feels like there should be a mach jstest command or something that handles all of this :/