Closed Bug 1556819 Opened 6 months ago Closed 5 months ago

AutoDebuggerJobQueueInterruption can interfere with replay

Categories

(Core :: Web Replay, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch patchSplinter Review

AutoDebuggerJobQueueInterruption is used when various debugger hooks are invoked, which can occur in different places when replaying than it did while recording. The callbacks invoked by this class can access the recording (taking some locks I think). It seems best to deal with this by disabling AutoDebuggerJobQueueInterruption when recording or replaying. We never spin up a nested event loop or promises in debugger hooks in a recording/replaying process (which would definitely perturb the recording!) so the run-to-completion issues which AutoDebuggerJobQueueInterruption is fixing cannot occur in the first place.

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement
Type: enhancement → defect
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/852a1ba09661
Prevent AutoDebuggerJobQueueInterruption from doing anything when recording/replaying, r=jimb.
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.