1556819 - AutoDebuggerJobQueueInterruption can interfere with replay

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

AutoDebuggerJobQueueInterruption is used when various debugger hooks are invoked, which can occur in different places when replaying than it did while recording. The callbacks invoked by this class can access the recording (taking some locks I think). It seems best to deal with this by disabling AutoDebuggerJobQueueInterruption when recording or replaying. We never spin up a nested event loop or promises in debugger hooks in a recording/replaying process (which would definitely perturb the recording!) so the run-to-completion issues which AutoDebuggerJobQueueInterruption is fixing cannot occur in the first place.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1556819 - Prevent AutoDebuggerJobQueueInterruption from doing anything when recording/replaying, r=jimb.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/852a1ba09661
Prevent AutoDebuggerJobQueueInterruption from doing anything when recording/replaying, r=jimb.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/852a1ba09661