Closed Bug 1556855 Opened 5 years ago Closed 5 years ago

Remove the layout.css.prefixes.webkit pref

Categories

(Core :: Layout, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: dholbert)

Details

Attachments

(5 files)

This pref has been enabled by default for a few years now (bug 1259345) and disabling it at this point would likely cause many web-compat issues.
So I think we should just remove this pref now.

Sounds good to me.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED

In particular:

  • The tests test_disabled_properties.html and
    test_animations_with_disabled_properties.html just want to be able to toggle
    some pref to turn off some property. So, this patch changes them to use a more
    recently-added pref-controlled property (-webkit-line-clamp). (We'll probably
    have to update these tests again when we eventually remove the pref for that
    property. Oh well.)

  • The tests 1265611-1.html and test_transitions_with_disabled_properties.html
    are more picky -- they require a pref-controlled property whose initial value
    is 'currentcolor'
    . We don't have any such property anymore, once the
    layout.css.prefixes.webkit pref is removed. For the crashtest, we might as
    well keep the test, with a disclaimer that its tested codepath has changed.
    And for the mochitest, we can't really "fix" the test, so let's just remove
    it. (We can take some comfort in knowing that the still-present test
    'test_animations_with_disabled_properties' is very similar and covers some of
    the same codepaths.)

(The pref is about to be removed, but even before its removal, it defaults to
'true' so these tests don't need to bother setting/checking it.)

Depends on D33804

From this point on, the webkit-prefixed CSS features that were previously
protected by this pref will now be unconditionally enabled.

Depends on D33806

This patch was generated automatically by running ./mach devtools-css-db

Depends on D33807

Just noticed that I need to rebase this on top of bug 1556808, which is adjusting the usage of this pref in EventListenerManager. (the end result will be the same, but the removed code is now slightly different.)

Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97c2f03da1f4
part 1: Adjust tests that depend on being able to disable properties via the pref 'layout.css.prefixes.webkit'. r=mats
https://hg.mozilla.org/integration/autoland/rev/6ddf597109f6
part 2: Update tests to assume that 'layout.css.prefixes.webkit' is already true. r=mats
https://hg.mozilla.org/integration/autoland/rev/a09f9cdd1a0b
part 3: Reduce indentation on some chunks of property_database.js that were moved in previous patch. r=mats
https://hg.mozilla.org/integration/autoland/rev/fdf0d6ca1288
part 4: Remove support for the layout.css.prefixes.webkit pref. r=mats
https://hg.mozilla.org/integration/autoland/rev/d0f8414a0881
part 5: Update devtools css database. r=mats
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: