1556880 - AttributeError: 'ReadOnlyNamespace' object has no attribute 'fpu'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The following happens when building with GCC, targeting armv7 linux.

checking for rust target triplet... Traceback (most recent call last):
  File "../configure.py", line 132, in <module>
    sys.exit(main(sys.argv))
  File "../configure.py", line 38, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 481, in run
    func(*args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 525, in _value_for
    return self._value_for_depends(obj)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/util.py", line 947, in method_call
    cache[args] = self.func(instance, *args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 534, in _value_for_depends
    value = obj.result()
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/util.py", line 947, in method_call
    cache[args] = self.func(instance, *args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 151, in result
    return self._func(*resolved_args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 1097, in wrapped
    return new_func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 787, in wrapper
    ret = template(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/moz.configure/checks.configure", line 58, in wrapped
    ret = func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 1097, in wrapped
    return new_func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/moz.configure/rust.configure", line 262, in rust_target
    arm_target.fpu == 'neon' and arm_target.thumb2:
AttributeError: 'ReadOnlyNamespace' object has no attribute 'fpu'

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target.

Also set fpu to None for when we don't find it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f00cff63f59
Support GCC ARM preprocessor defines to detect the ARM target. r=chmanchester

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9069799 [details]
Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target.

Beta/Release Uplift Approval Request

• User impact if declined: Build failure on Debian armhf with GCC.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minimal changes to the configure script, that have no effect on builds other than the ones that were broken. Practically speaking, this is NPOTB for Mozilla.
• String changes made/needed: N/A

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7f00cff63f59

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9069799 [details]
Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target.

tier3 build fix, approved for 68.0b8

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa3b94c7550a