[about:addons] Handle disabling/reloading better for inline options
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(1 file)
STR
- Install an extension with inline (the tab on details page) options, like Tree Style Tab
- On the list view, select Preferences for the extension
- Disable the extension
Expected results: The selected view is changed to Details
Actual results: The Preferences tab is hidden, but the view does not change
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00ab4104c304 Hide inline options when add-on is disabled r=rpl
Comment 4•5 years ago
|
||
Backed out changeset 00ab4104c304 (bug 1557175) for browser-chrome failures at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_optionsPage_popups.js
Backout: https://hg.mozilla.org/integration/autoland/rev/4db620732a3c1978e0d08148de5341d6a2398fef
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=00ab4104c30487f9cf191a5aadfd085276c292a7
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257433808&repo=autoland&lineNumber=3066
task 2019-07-19T18:52:09.875Z] 18:52:09 INFO - TEST-START | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_optionsPage_popups.js
[task 2019-07-19T18:53:40.046Z] 18:53:40 INFO - TEST-INFO | started process screentopng
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - TEST-INFO | screentopng: exit 0
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Buffered messages logged at 18:52:09
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Entering test bound test_tab_options_popups
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Extension loaded
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Buffered messages logged at 18:52:10
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 112}]
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Buffered messages logged at 18:52:11
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Trigger context menu in the extension options page
[task 2019-07-19T18:53:40.531Z] 18:53:40 INFO - Wait the context menu to be shown
[task 2019-07-19T18:53:40.535Z] 18:53:40 INFO - Buffered messages logged at 18:52:13
[task 2019-07-19T18:53:40.537Z] 18:53:40 INFO - Console message: [JavaScript Error: "A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
[task 2019-07-19T18:53:40.538Z] 18:53:40 INFO - See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
[task 2019-07-19T18:53:40.539Z] 18:53:40 INFO -
[task 2019-07-19T18:53:40.540Z] 18:53:40 INFO - Date: Fri Jul 19 2019 18:52:12 GMT+0000 (Coordinated Universal Time)
[task 2019-07-19T18:53:40.541Z] 18:53:40 INFO - Full Message: TypeError: el is null
[task 2019-07-19T18:53:40.542Z] 18:53:40 INFO - Full Stack: JS frame :: resource://gre/modules/Promise-backend.js :: register :: line 209
[task 2019-07-19T18:53:40.543Z] 18:53:40 INFO - JS frame :: resource://gre/modules/Promise-backend.js :: completePromise :: line 745
[task 2019-07-19T18:53:40.544Z] 18:53:40 INFO - JS frame :: resource://testing-common/ContentTask.jsm :: receiveMessage :: line 106"]
[task 2019-07-19T18:53:40.548Z] 18:53:40 INFO - Buffered messages finished
[task 2019-07-19T18:53:40.549Z] 18:53:40 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_optionsPage_popups.js | Test timed out -
[task 2019-07-19T18:53:40.550Z] 18:53:40 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-19T18:53:40.551Z] 18:53:40 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_optionsPage_popups.js | message queue is empty - Got ["options-page:loaded"], expected []
[task 2019-07-19T18:53:40.552Z] 18:53:40 INFO - Stack trace:
[task 2019-07-19T18:53:40.553Z] 18:53:40 INFO - chrome://mochikit/content/browser-test.js:test_is:1591
[task 2019-07-19T18:53:40.554Z] 18:53:40 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:27
[task 2019-07-19T18:53:40.555Z] 18:53:40 INFO - chrome://mochikit/content/browser-test.js:nextTest:856
[task 2019-07-19T18:53:40.556Z] 18:53:40 INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1467
[task 2019-07-19T18:53:40.557Z] 18:53:40 INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1414
[task 2019-07-19T18:53:40.558Z] 18:53:40 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
[task 2019-07-19T18:53:40.559Z] 18:53:40 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-07-19T18:53:40.560Z] 18:53:40 INFO - Not taking screenshot here: see the one that was previously logged
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/140cb3a190e9 Hide inline options when add-on is disabled r=rpl
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
I'm inclined to let this fix ride the trains given that Fx69 is almost to RC now. WDYT, Mark?
Assignee | ||
Comment 8•5 years ago
|
||
It has pretty good test coverage so I wouldn't be too concerned about uplifting it. I'm also fine with it riding the trains though.
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Verified the fix using the latest Nightly (70.0a1/20190821215524) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.
After disabling the extension, the ‘Preferences’ / ‘Options’ tab is hidden and the view changes to the ‘Details’ tab, thus confirming the fix.
Description
•