Remove AppCacheInsecure deprecated operation
Categories
(Core :: DOM: Core & HTML, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: u644803)
References
Details
(Whiteboard: [good first bug][mentor=ehsan])
Attachments
(1 file)
Bug 1354175 removed support for AppCache from insecure contexts. We have not yet removed the deprecated operation warning for it. We should do that since that warning will never be triggered now.
All that is needed to fix this bug is to remove the following blocks of code essentially, this is the code that defines this deprecated operation warning code and emits it.
- https://searchfox.org/mozilla-central/rev/153172de0c5bfca31ef861bd8fc0995f44cada6a/dom/base/nsDeprecatedOperationList.h#31
- https://searchfox.org/mozilla-central/rev/153172de0c5bfca31ef861bd8fc0995f44cada6a/dom/locales/en-US/chrome/dom/dom.properties#194-195
- https://searchfox.org/mozilla-central/rev/153172de0c5bfca31ef861bd8fc0995f44cada6a/netwerk/protocol/http/nsHttpChannel.cpp#9555-9560
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
I'm interested in this, can I be made assignee?
|
Reporter | |
Comment 2•5 years ago
|
||
Since you took bug 1557223 I'm inclined to leave this bug for another contributor, if that's OK. :-) We use "good first bugs" as entry points for new contributors to get familiarized with the process of contributing a patch to Mozilla without necessarily facing too much difficulties in creating the patch itself (since there are other things to learn, such as how to build your change, make sure it passes all of our tests, submit it for review, get it landed, etc.)
Typically after a contributor finishes their first bug we nudge them towards more challenging and interesting work that's a tiny bit more complex than good first bugs, so I was thinking perhaps I could direct you to one such bug after bug 1557223 instead. What do you think?
|
|
||
Comment 3•5 years ago
|
||
Sure, that sounds fantastic!
|
|
Reporter | |
Comment 5•5 years ago
|
||
Sure, thanks for your interest! Let me know if you needed any help.
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/475dca202500 Remove AppCacheInsecure deprecated operation r=Ehsan
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•