1557254 - Disallow lossy ACString conversions

Status: REOPENED

(Core :: XPConnect, defect, P2)

Description

[Masatoshi Kimura [:emk]]

ACString is a footgun. For example see bug 1549386.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1557254 - Enable char range check on Nightly/DevEdition and make warnings more dire. r?dmajor

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c976344b69
Enable char range check on Nightly/DevEdition and make warnings more dire. r=hsivonen

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/13c976344b69

Comment 4

[Andreea Pavel [:apavel]]

Backed out for causing bug 1558836 and bug 1558852

Backout: https://hg.mozilla.org/mozilla-central/rev/3ab360f56144d5c93dbb7ca8e1adab90f2a7f29b

Comment 5

[:Gijs (he/him)]

In bug 1558836, at least https://searchfox.org/mozilla-central/source/netwerk/cookie/nsICookieManager.idl#124-133 seems to be causing crashes with this patch applied, because sessionstore tries to restore cookies that have contents that trip this check.

Comment 6

[Masatoshi Kimura [:emk]]

ping? (feel free to redirect if others should review the JS stuff)

Comment 7

[Henri Sivonen (:hsivonen)]

(In reply to Masatoshi Kimura [:emk] from comment #6)

ping? (feel free to redirect if others should review the JS stuff)

Sorry. Phabricator is really unclear about whose action is needed next.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:peterv, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[:Gijs (he/him)]

What's the current state here? Looks like the patch is ready to re-land but it needs data review for the added crash data field? Or are there other blockers I'm not seeing?

Comment 10

[Masatoshi Kimura [:emk]]

Yes, I'll submit data-review request.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:peterv, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 12

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.