1557403 - Crash in [@ style::gecko_bindings::structs::root::nsStyleImage::into_image]

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-f90566f3-6db4-4036-9d0e-63eb30190606.

Top 10 frames of crashing thread:

0 xul.dll GeckoCrash toolkit/xre/nsAppRunner.cpp:5174
1 xul.dll static void gkrust_shared::panic_hook toolkit/library/rust/shared/lib.rs:244
2 xul.dll static void core::ops::function::Fn::call<fn src/libcore/ops/function.rs:69
3 xul.dll static void std::panicking::rust_panic_with_hook src/libstd/panicking.rs:478
4 xul.dll static void std::panicking::continue_panic_fmt src/libstd/panicking.rs:381
5 xul.dll void std::panicking::begin_panic_fmt src/libstd/panicking.rs:336
6 xul.dll static union core::option::Option<style::values::generics::image::Image<style::values::generics::image::Gradient<style::values::computed::image::LineDirection, style::values::computed::length::CSSPixelLength, style::values::computed::length::LengthPercentage, style::values::generics::position::GenericPosition<style::values::computed::length::LengthPercentage, style::values::computed::length::LengthPercentage>, style::values::generics::color::GenericColor<cssparser::color::RGBA>>, style::values::generics::image::MozImageRect<style::values::computed::NumberOrPercentage, style::gecko::url::ComputedImageUrl>, style::gecko::url::ComputedImageUrl>> style::gecko_bindings::structs::root::nsStyleImage::into_image servo/components/style/gecko/conversions.rs:355
7 xul.dll static struct style::properties::longhands::background_image::computed_value::OwnedList<style::values::Either<style::values::None_, style::values::generics::image::Image<style::values::generics::image::Gradient<style::values::computed::image::LineDirection, style::values::computed::length::CSSPixelLength, style::values::computed::length::LengthPercentage, style::values::generics::position::GenericPosition<style::values::computed::length::LengthPercentage, style::values::computed::length::LengthPercentage>, style::values::generics::color::GenericColor<cssparser::color::RGBA>>, style::values::generics::image::MozImageRect<style::values::computed::NumberOrPercentage, style::gecko::url::ComputedImageUrl>, style::gecko::url::ComputedImageUrl>>> style::gecko_bindings::structs::root::mozilla::GeckoBackground::clone_background_image x86_64-pc-windows-msvc/release/build/style-d70eb76fc7337cbc/out/gecko_properties.rs:12097
8 xul.dll static core::result::Result style::gecko_properties::ComputedValues::get_longhand_property_value<nsstring::nsAString> x86_64-pc-windows-msvc/release/build/style-d70eb76fc7337cbc/out/properties.rs:70879
9 xul.dll void geckoservo::glue::Servo_GetPropertyValue servo/ports/geckolib/glue.rs:5935

There are 100 crashes (from 32 installations) in nightly 69 with buildid 20190606112416. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1557110.

[1] https://hg.mozilla.org/mozilla-central/rev?node=25354cfea038

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I can repro this on https://online.citi.com/US/JSO/loginpage/retarget.action.

Bug 1557212 will fix this.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I'll land a fix anyway so it stops crashing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e77c7f8edc6
Handle default angle in radians. r=me

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9e77c7f8edc6

Comment 8

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.