1557434 - Split nsPrintObject::Init into separate root-object and nested-object init methods

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P2)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1557434. Split nsPrintObject::Init into separate root-object and nested-object init methods. r=bobowen

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1557434. Rename nsPrintJob::BuildDocTree to BuildNestedPrintObjects. r=bobowen

The previous splitting of nsPrintObject::Init made clear that in fact this
method does not create documents at all! This new name better describes what
it does.

Depends on D34006

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1557434. Remove nsPrintJob::mPrintPreview. r=bobowen

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1557434. Remove nsPrintObject::mPrintPreview. r=bobowen

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5732da1844b
Split nsPrintObject::Init into separate root-object and nested-object init methods. r=bobowen
https://hg.mozilla.org/integration/mozilla-inbound/rev/f39ff7aa10b3
Rename nsPrintJob::BuildDocTree to BuildNestedPrintObjects. r=bobowen
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d538a3e517
Remove nsPrintObject::mPrintPreview. r=bobowen

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d5732da1844b
https://hg.mozilla.org/mozilla-central/rev/f39ff7aa10b3
https://hg.mozilla.org/mozilla-central/rev/f9d538a3e517