Closed Bug 1557506 Opened 1 year ago Closed 5 months ago

Remove [array] use in xpidl from chat/

Categories

(Chat Core :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 71

People

(Reporter: mkmelin, Assigned: clokep)

References

Details

Attachments

(1 file)

Summary: emove [array] use in xpidl from chat/ → Remove [array] use in xpidl from chat/
Attached patch Patch v1Splinter Review

I believe this makes all the required changes. I tested this with the following:

  1. Create an IRC account on moznet.
  2. Join a channel (and also join that channel from another client).
  3. Type "/<tab><tab>" should show a list of commands that are accessible.
  4. Type "/list<enter>" and you should have another conversation open with a list of all channels.
  5. Hover over a participants name in the conversation UI and more information should pop up.
  6. Restart your Thunderbird.
  7. Rejoin the same channel.
  8. Ensure you can view the historical conversation from the logs.
  9. In the account list, right click on one and click "Copy Debug Log".
  10. Paste this somewhere and ensure there's content.
  11. Add someone to your contact list and ensure status, etc. is working properly for them.
  12. Double click on the person in your contact list and a conversation should open.
  13. Type a message that's too long for a single IRC message (you'll see the counter appear in the bottom right when you get close).
  14. Send the message and ensure both clients see the same content (and that it is properly broken up).
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #9092699 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9092699 [details] [diff] [review]
Patch v1

Review of attachment 9092699 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, this is pretty nice cleanup! r=mkmelin

::: chat/components/public/imIConversationsService.idl
@@ +93,5 @@
>  [scriptable, uuid(3f88cc5c-6940-4eb5-a576-c65770f49ce9)]
>  interface imIMessage: prplIMessage {
> +  attribute boolean cancelled;
> +  // Holds the sender color for Chats.
> +  // Empty string by default, it is set by the conversation binding.

For these, please update to jsdoc style documentation comments. /** */
Attachment #9092699 - Flags: review?(mkmelin+mozilla) → review+

(In reply to Magnus Melin [:mkmelin] from comment #2)

For these, please update to jsdoc style documentation comments. /** */

Filed bug 1581202 as a follow-up to do this.

I'll land it with the next lot.

Keywords: checkin-needed

Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/a3a6442dde2f
Remove [array] use in xpidl from chat/. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 71
Regressions: 1592505
You need to log in before you can comment on or make changes to this bug.