about: Use XML parser for XHTML services

RESOLVED FIXED in mozilla1.1beta

Status

SeaMonkey
UI Design
RESOLVED FIXED
16 years ago
11 years ago

People

(Reporter: Alexey Chernyak, Assigned: Alexey Chernyak)

Tracking

({qawanted})

Trunk
mozilla1.1beta
qawanted

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.75 KB, patch
Alexey Chernyak
: review+
Alexey Chernyak
: superreview+
Alexey Chernyak
: approval+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
In bug 95768 I have converted most of about: services into XHTML 1.1.
However they still take path through HTML parser instead of XML parser.

I attaching patch for the following about: services to be treated as XML:

about:
about:mozilla
about:cache-entry

I left about:cache with HTML parser because we still do not have incremental XML
content sink (see bug 18333).
(Assignee)

Comment 1

16 years ago
Created attachment 90206 [details] [diff] [review]
patch

Together with this patch the following files MUST be renamed:

http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/locale/en-US/about.html
to about.xhtml
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/mozilla.html
to mozilla.xhtml

The following file is an old version of mozilla.html and I don't know who uses
it.
http://lxr.mozilla.org/mozilla/source/l10n/us/xp/mozilla.html
We might want to replace it with mozilla.xhtml from above.

The about:cache-entry service stream is changed from text/html to
application/xhtml+xml.


The patch also HTML-escapes URLs in about:cache and about:cache-entry services
to make them fully XHTML valid, and to avoid any possible security issues.
(Assignee)

Comment 2

16 years ago
I think I've covered all the files needed for this change. Can someone please
test this to see if I didn't miss anything.

CCing leaf who is able to rename files while preserving their history.
Keywords: mozilla1.1, patch, review
(Assignee)

Updated

16 years ago
Depends on: 18333
(Assignee)

Updated

16 years ago
Target Milestone: --- → mozilla1.1beta
Comment on attachment 90206 [details] [diff] [review]
patch

sr=jst
Attachment #90206 - Flags: superreview+

Updated

16 years ago
Attachment #90206 - Flags: review+

Comment 4

16 years ago
Who tests XHTML layout? They should be the QA owner. In fact, this should
probably go to any XHTML related component.
Keywords: qawanted

Comment 5

16 years ago
so, about:config is still html, right?

I have copied the ,v files; i'll let someone that knows more about the code do
the checkin; jst?

Alex, if you can't checkin, i suggest you reassign to jst in case he isn't
reading his bugmail ;)
We still need approval from drivers@mozilla.org for checking this in, get that
and I'll be happy to land this...

Comment 7

16 years ago
Comment on attachment 90206 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.
Attachment #90206 - Flags: approval+
(Assignee)

Comment 8

16 years ago
Created attachment 91595 [details] [diff] [review]
same patch with fixed CVS paths so it can be applied
Attachment #90206 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #91595 - Flags: superreview+
Attachment #91595 - Flags: review+
Attachment #91595 - Flags: approval+
The patch still doesn't apply because it appears to be hand edited and patch
cries.  That notwithstanding, after manually typing in filenames to patch, it
appears to break my Linux opt depend build.  I don't have the time to
investigate it fully ATM...
Alexey, so ok I've got it to work.  THe problem wasn't with the patch but with a
few changes I had in my tree.  Anyway, your approval had already expired by the
time you asked me to check this in.  Please get your approval renewed (they
expire after 3 days) and I will check it in for you.
Checked in with a=asa (renewed via email).
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 12

16 years ago
-> XP apps for qa, per samir.
Component: Networking → XP Apps
Summary: Use XML parser for XHTML about: services → about: Use XML parser for XHTML services
Product: Core → Mozilla Application Suite

Updated

11 years ago
QA Contact: benc → nobody
You need to log in before you can comment on or make changes to this bug.