155752 - about: Use XML parser for XHTML services

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Alexey Chernyak]

In bug 95768 I have converted most of about: services into XHTML 1.1.
However they still take path through HTML parser instead of XML parser.

I attaching patch for the following about: services to be treated as XML:

about:
about:mozilla
about:cache-entry

I left about:cache with HTML parser because we still do not have incremental XML
content sink (see bug 18333).

Comment 1

[Alexey Chernyak]

Attachment: patch

Together with this patch the following files MUST be renamed:

http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/locale/en-US/about.html
to about.xhtml
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/mozilla.html
to mozilla.xhtml

The following file is an old version of mozilla.html and I don't know who uses
it.
http://lxr.mozilla.org/mozilla/source/l10n/us/xp/mozilla.html
We might want to replace it with mozilla.xhtml from above.

The about:cache-entry service stream is changed from text/html to
application/xhtml+xml.


The patch also HTML-escapes URLs in about:cache and about:cache-entry services
to make them fully XHTML valid, and to avoid any possible security issues.

Comment 2

[Alexey Chernyak]

I think I've covered all the files needed for this change. Can someone please
test this to see if I didn't miss anything.

CCing leaf who is able to rename files while preserving their history.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 90206 [details] [diff] [review]
patch

sr=jst

Comment 4

[benc]

Who tests XHTML layout? They should be the QA owner. In fact, this should
probably go to any XHTML related component.

Comment 5

[Daniel (Leaf) Nunes]

so, about:config is still html, right?

I have copied the ,v files; i'll let someone that knows more about the code do
the checkin; jst?

Alex, if you can't checkin, i suggest you reassign to jst in case he isn't
reading his bugmail ;)

Comment 6

[Johnny Stenback (:jst)]

We still need approval from [e-mail] for checking this in, get that
and I'll be happy to land this...

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 90206 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 8

[Alexey Chernyak]

Attachment: same patch with fixed CVS paths so it can be applied

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

The patch still doesn't apply because it appears to be hand edited and patch
cries.  That notwithstanding, after manually typing in filenames to patch, it
appears to break my Linux opt depend build.  I don't have the time to
investigate it fully ATM...

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Alexey, so ok I've got it to work.  THe problem wasn't with the patch but with a
few changes I had in my tree.  Anyway, your approval had already expired by the
time you asked me to check this in.  Please get your approval renewed (they
expire after 3 days) and I will check it in for you.

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in with a=asa (renewed via email).

Comment 12

[benc]

-> XP apps for qa, per samir.