1557548 - [webvtt] enable wpt 'navigate_cue_position.html'

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

For wpt navigate_cue_position.html, it's used to test whether cue is in the correct position after navigation, we acutally have no need to add the control and add an offset in reference file, which is totally unrelated with navigation.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1557548 - part1 : remove 'controls' attribute from video.

It's no need to add 'controls' attribute in this test because it's totally unrelated with navigation and we even have to add extra offset for the cue text in the reference file.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1557548 - part2 : enable wpt 'navigate_cue_position.html'.

Disable on Windows is because sometime iframe can't load successfully, which makes our test file showing wrong image.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd473827dfd4
part1 : remove 'controls' attribute from video. r=heycam
https://hg.mozilla.org/integration/autoland/rev/a82a47eff15b
part2 : enable wpt 'navigate_cue_position.html'. r=heycam

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17321 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cd473827dfd4
https://hg.mozilla.org/mozilla-central/rev/a82a47eff15b

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged