1557793 - Stop using [array] in nsIStringBundle

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Boris Zbarsky [:bzbarsky]]

Jorg, you will likely need c-c changes for this... The JS bits are unlikely to cause breakage, since they will basically correspond to the last arg being ignored as extraneous, but might want cleanup anyway. The C++ bits will need the usual bustage fixes.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=pike

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1557793 part 3. Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API. r=smaug

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles

It looks like bug 1321412 changed the number of params but didn't update the
template parameter, and then bug 1364221 followed its example of not matching
the template parameter to the actual number of params. As a result we're
passing an array with one garbage pointer to the callee, and it just happens
that the callee doesn't examine that pointer. But that's about to change.

Comment 4

[Jorg K (CEST = GMT+2)]

Quite a bit of work in C-C, about 40 files. I hope you won't land this before Monday ;-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'll be shocked if this gets reviewed before Monday.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17869bc540e5
part 1.  Fix incorrect template arguments in AnimationPerformanceWarning.  r=birtles
https://hg.mozilla.org/integration/autoland/rev/33686f46a5ba
part 2.  Stop using [array] in nsIStringBundle.  r=Pike
https://hg.mozilla.org/integration/autoland/rev/89b5e0496b75
part 3.  Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API.  r=smaug

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/17869bc540e5
https://hg.mozilla.org/mozilla-central/rev/33686f46a5ba
https://hg.mozilla.org/mozilla-central/rev/89b5e0496b75