Closed Bug 1557793 Opened 6 months ago Closed 6 months ago

Stop using [array] in nsIStringBundle

Categories

(Core :: Internationalization, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Jorg, you will likely need c-c changes for this... The JS bits are unlikely to cause breakage, since they will basically correspond to the last arg being ignored as extraneous, but might want cleanup anyway. The C++ bits will need the usual bustage fixes.

It looks like bug 1321412 changed the number of params but didn't update the
template parameter, and then bug 1364221 followed its example of not matching
the template parameter to the actual number of params. As a result we're
passing an array with one garbage pointer to the callee, and it just happens
that the callee doesn't examine that pointer. But that's about to change.

Attachment #9070641 - Attachment description: Bug 1557793 part 1. Stop using [array] in nsIStringBundle. r=pike → Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=pike
Attachment #9070646 - Attachment description: Bug 1557793 part 2. Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API. r=smaug → Bug 1557793 part 3. Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API. r=smaug

Quite a bit of work in C-C, about 40 files. I hope you won't land this before Monday ;-)

I'll be shocked if this gets reviewed before Monday.

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17869bc540e5
part 1.  Fix incorrect template arguments in AnimationPerformanceWarning.  r=birtles
https://hg.mozilla.org/integration/autoland/rev/33686f46a5ba
part 2.  Stop using [array] in nsIStringBundle.  r=Pike
https://hg.mozilla.org/integration/autoland/rev/89b5e0496b75
part 3.  Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API.  r=smaug
You need to log in before you can comment on or make changes to this bug.