1557844 - enabling Vorbis decoding on RDD causes Windows CoInitializeEx failure

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Michael Froman [:mjf]]

We need re-add ProcessRuntime so mscom is properly init'd. This was removed during one of the early reviews.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1557844 - add back ProcessRuntime in RDD for mscom init. r?jya

This fixes a CoInitializeEx failure when enabling Vorbis
decoding on RDD.

Comment 2

[Michael Froman [:mjf]]

Just a note, without this fix, CoInitializeEx in RemoteDecoderManagerParent.cpp returns E_OUTOFMEMORY. With this fix, we get a different error (also a CoInitializeEx failure, but no win ApartmentRegion.h) which is reported in Bug 1553249.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1d251e5e26f
add back ProcessRuntime in RDD for mscom init. r=jya

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e1d251e5e26f

Comment 5

[Tom Ritter [:tjr]]

Comment on attachment 9070715 [details]
Bug 1557844 - add back ProcessRuntime in RDD for mscom init. r?jya

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Tor is built on ESR; and this patch is necessary for the RDD process to work in the MinGW build (which Tor uses)
• User impact if declined: Tor will need to carry a separate patch
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): I believe this patch is not risky, even though it applies to all platforms, because it is a bugfix needed for normal RDD process operation for Vorbis, just not AV1 (on clang-cl builds). But I'm going to confirm this.
• String or UUID changes made by this patch:

Comment 6

[Tom Ritter [:tjr]]

Michael, do you have any concerns about this patch landing in ESR 68?

Comment 7

[Michael Froman [:mjf]]

This should be low risk.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9070715 [details]
Bug 1557844 - add back ProcessRuntime in RDD for mscom init. r?jya

Fixes an RDD issue affecting Tor browser. No issues with the patch on Beta so far. Approved for 68.1esr.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/2160cc9168ad